Add PRNG support with singleton pattern #7360
Closed
+221
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested changes
Jun 4, 2025
cirq-core/cirq/value/prng.py
Outdated
|
|
||
| # Singleton generator instance for None input, created on demand. | ||
| # Avoids creating many Generators if parse_prng(None) is called frequently. | ||
| _NONE_PRNG_INSTANCE: np.random.Generator = None |
There was a problem hiding this comment.
a global state is not something we want. a global generator will come with two negative side effects 1) it will break multiprocessing/multithreading 2) it will be a shared state that may result in correlated simulation results
creating new generators is fine
cirq-core/cirq/value/prng.py
Outdated
| @@ -0,0 +1,88 @@ | |||
| # Copyright 2024 The Cirq Developers | |||
There was a problem hiding this comment.
this code is being depveloped in 2025, same goes for the other files
Suggested change
| # Copyright 2024 The Cirq Developers | |
| # Copyright 2025 The Cirq Developers |
github-actions
bot
added
size: L
This merge integrates upstream changes with our local PRNG updates, including: - Removed singleton PRNG pattern - Updated copyright year - Fixed formatting and linting issues
|
Closing this PR for now due to shifting priorities. If anyone wants to pick this up, should just be a few modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6531
This PR introduces a new
PRNG_OR_SEED_LIKEtype and parse_prng function to improve random number generation in Cirq. The key changes are:New
PRNG_OR_SEED_LIKEtype:None,np.random.Generator, andnp.random.RandomStateRANDOM_STATE_OR_SEED_LIKESingleton pattern for
Noneinput:np.random.Generatorinstance forNoneinputsImproved random number generation:
np.random.Generatorobjectsnp.random.RandomStateconversionnp.randommodule as inputFixes:
The implementation includes comprehensive tests covering:
None