Support merge symbolized 1 qubit gate transformer #7393
Conversation
babacry
changed the title
babacry
force-pushed
the
merge_single_1
branch
5 times, most recently
from
c283401 to
85586b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7393 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 1112 1112
Lines 97993 98076 +83
=======================================
+ Hits 96714 96797 +83
Misses 1279 1279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@NoureldinYosri @eliottrosenberg I re-synced and refactored #7149 here, re-review calls! Thank you! And thank you Nour for noticing this and self assigning! |
Good catch!! I should align the circuit after the parameterization. Patched. Could you help take another look? @eliottrosenberg |
…ched circuit structures in parameterizations
|
I also added unit tests by calling gauge_compiling.as_sweep as input similar to the colab: test case. |
| def test_case1(self): | ||
| """Test case diagram. | ||
| Input circuit: | ||
| 0: ───X─────────@──────────H[ignore]───H───X───PhXZ(a=a0,x=x0,z=z0)───X───PhXZ(a=a1,x=x1,z=z1)─── # pylint: disable=line-too-long |
There was a problem hiding this comment.
the pylint statement here won't work since it is seen as just text inside a comment. I think you should just reduce the amout of ─ to save space
There was a problem hiding this comment.
Yeah, good suggestion. This is really annoying.
|
Thanks Nour! |
Merge single qubit gates for symbolized circuits. It is a updated version of #7149 where tag_transformers and symbolize transformers are already merged. --------- Co-authored-by: eliottrosenberg <61400172+eliottrosenberg@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merge single qubit gates for symbolized circuits. It is a updated version of quantumlib#7149 where tag_transformers and symbolize transformers are already merged. --------- Co-authored-by: eliottrosenberg <61400172+eliottrosenberg@users.noreply.github.com>
Merge single qubit gates for symbolized circuits.
It is a updated version of #7149 where tag_transformers and symbolize transformers are already merged.