QVM - deprecate default gate_times_ns in noise_properties_from_calibration #7399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d virtual processors Add tests for all known virtual processors.
…tum_virtual_machine
…times_ns Show deprecation warning when `gate_times_ns` argument is not provided. Introduce literal "sycamore" value as an alias for legacy defaults.
Replace use of noise_properties_from_calibration for more convenience with gate_times_ns argument.
pavoljuhas
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97709 97737 +28
=======================================
+ Hits 96427 96455 +28
Misses 1282 1282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eliottrosenberg
requested changes
May 31, 2025
Comment on lines
117
to
120
| gate_times_ns: Map of gate durations in nanoseconds or "sycamore" | ||
| to use the Sycamore gate times listed in `known_devices.py`. | ||
| Note this argument has changed from optional to mandatory. | ||
| Use "sycamore" to get the legacy default values. |
Collaborator
There was a problem hiding this comment.
Calling the old defaults "Sycamore" values might give the false impression that gates on Sycamore devices always used these durations. For example, in the M2 paper, the CZ gate was 34 ns, not 32 ns, and readout was 500 ns, not 4000 ns, even though that was a Sycamore processor (see M2 SM, Sec I.D, I.E). Maybe we can call them old defaults or something. We can also have a name for the durations in the new QVM.
Collaborator
Author
There was a problem hiding this comment.
Good point - done in 0e7c505. Renamed to "legacy".
Update notebooks in next PR. They need a dev release on PyPI first. This reverts commit ff2f7d1.
Should be less confusing than "sycamore".
dstrain115
approved these changes
Jun 2, 2025
pavoljuhas
added
the
BREAKING CHANGE
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…ation (quantumlib#7399) * `noise_properties_from_calibration` - show deprecation warning when called without `gate_times_ns` and introduce literal "legacy" as an alias for the old gate times default. * `load_device_noise_properties` - update to use legacy gate times for old virtual processors and make tests more comprehensive. Related to b/395705720
This was referenced Aug 5, 2025
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Sep 9, 2025
…tion The default value for the `gate_times_ns` argument of `noise_properties_from_calibration` was deprecated in quantumlib#7399. Here we make the argument mandatory. Note the literal "legacy" value, i.e., `gate_times_ns="legacy"`, can be used as a stand-in for the old default. Related to b/395705720
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…tion (#7644) The default value for the `gate_times_ns` argument of `noise_properties_from_calibration` was deprecated in #7399. Here we make the argument mandatory. Note the literal "legacy" value, i.e., `gate_times_ns="legacy"`, can be used as a stand-in for the old default. Related to b/395705720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noise_properties_from_calibration- show deprecation warning whencalled without
gate_times_nsand introduce literal "legacy" asan alias for the old gate times default.
load_device_noise_properties- update to use legacy gate times forold virtual processors and make tests more comprehensive.
Related to b/395705720