Combining readout circuits for QWC pauli strings in the measure_pauli_strings method
#7416
+86
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: S
github-actions
bot
added
size: M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7416 +/- ##
==========================================
- Coverage 98.69% 98.69% -0.01%
==========================================
Files 1112 1112
Lines 97966 97993 +27
==========================================
+ Hits 96688 96714 +26
- Misses 1278 1279 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eliottrosenberg
approved these changes
Jun 11, 2025
Thank you!! I will wait for Nour to give a stamp and submit this |
NoureldinYosri
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
thanks @ddddddanni , overall looks good, just a couple of nits + coverage
| qubits_to_error: SingleQubitReadoutCalibrationResult, readout_qubits: list[ops.Qid] | ||
| ) -> SingleQubitReadoutCalibrationResult: | ||
| """Builds a calibration result for the specific readout qubits.""" | ||
| return SingleQubitReadoutCalibrationResult( |
There was a problem hiding this comment.
nit: this should be a SingleQubitReadoutCalibrationResult method
class SingleQubitReadoutCalibrationResult:
...
def readout_result_for_qubits(self, qubits) -> 'SingleQubitReadoutCalibrationResult':
...There was a problem hiding this comment.
Sure! Moved the method to under SingleQubitReadoutCalibrationResult
| @@ -217,6 +217,31 @@ def _normalize_input_paulis( | |||
| return cast(dict[circuits.FrozenCircuit, list[list[ops.PauliString]]], circuits_to_pauli) | |||
|
|
|||
|
|
|||
| def _extract_readout_qubits(pauli_strings: list[ops.PauliString]) -> list[ops.Qid]: | |||
| """Extracts unique qubits from a list of QWC Pauli strings.""" | |||
| qubits = set() | |||
There was a problem hiding this comment.
nit:
Suggested change
| qubits = set() | |
| return sorted(set(q for ps in pauli_strings for q in op.qubits)) |
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 25, 2025
…uli_strings``` method (quantumlib#7416) [PR quantumlib#7236](quantumlib#7236) adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously. However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7236 adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously.
However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.