Skip to content

Domino looses dependency links for artifacts managed at a custom version #399

@ppalaga

Description

@ppalaga

I have an extension that transitively depends on foo:bar via bar:baz. foo:bar is managed in my BOM at 1.2.3, but the dependency of bar:baz is foo:bar:1.1.1.

In this situation, the repo dependecy graph delivered by Domino has foo:bar as a root artifact, but correctly it should hang on bar:baz.

The root cause is in io.quarkus.domino.ProjectDependencyResolver.configureReleaseRepoDeps()

final ArtifactDependency dirArt = artifactDeps.get(ArtifactCoords.of(a.getGroupId(), a.getArtifactId(),
a.getClassifier(), a.getExtension(), a.getVersion()));
if (dirArt != null) {
d.addDependency(dirArt);
}

where artifactDeps.get() is called with foo:bar:1.1.1, but there is only the managed foo:bar:1.2.3 available in artifactDeps.

I guess checking the version against the BOM constraints before searching in artifactDeps could be the right fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions