Skip to content

Commit 15e658d

Browse files
authored
Set correct value for ExecType in ExecutionReport (#404) (Executor example application)
Starting from FIX.4.3, ExecType.PARTIAL_FILL and ExecType.FILL were removed and replaced by ExecType.TRADE.
1 parent 99c401a commit 15e658d

File tree

1 file changed

+6
-6
lines changed
  • quickfixj-examples/executor/src/main/java/quickfix/examples/executor

1 file changed

+6
-6
lines changed

quickfixj-examples/executor/src/main/java/quickfix/examples/executor/Application.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ public void onMessage(quickfix.fix43.NewOrderSingle order, SessionID sessionID)
315315
Price price = getPrice(order);
316316

317317
quickfix.fix43.ExecutionReport accept = new quickfix.fix43.ExecutionReport(
318-
genOrderID(), genExecID(), new ExecType(ExecType.FILL), new OrdStatus(
318+
genOrderID(), genExecID(), new ExecType(ExecType.NEW), new OrdStatus(
319319
OrdStatus.NEW), order.getSide(), new LeavesQty(order.getOrderQty()
320320
.getValue()), new CumQty(0), new AvgPx(0));
321321

@@ -325,7 +325,7 @@ public void onMessage(quickfix.fix43.NewOrderSingle order, SessionID sessionID)
325325

326326
if (isOrderExecutable(order, price)) {
327327
quickfix.fix43.ExecutionReport executionReport = new quickfix.fix43.ExecutionReport(genOrderID(),
328-
genExecID(), new ExecType(ExecType.FILL), new OrdStatus(OrdStatus.FILLED), order.getSide(),
328+
genExecID(), new ExecType(ExecType.TRADE), new OrdStatus(OrdStatus.FILLED), order.getSide(),
329329
new LeavesQty(0), new CumQty(orderQty.getValue()), new AvgPx(price.getValue()));
330330

331331
executionReport.set(order.getClOrdID());
@@ -350,7 +350,7 @@ public void onMessage(quickfix.fix44.NewOrderSingle order, SessionID sessionID)
350350
Price price = getPrice(order);
351351

352352
quickfix.fix44.ExecutionReport accept = new quickfix.fix44.ExecutionReport(
353-
genOrderID(), genExecID(), new ExecType(ExecType.FILL), new OrdStatus(
353+
genOrderID(), genExecID(), new ExecType(ExecType.NEW), new OrdStatus(
354354
OrdStatus.NEW), order.getSide(), new LeavesQty(order.getOrderQty()
355355
.getValue()), new CumQty(0), new AvgPx(0));
356356

@@ -360,7 +360,7 @@ public void onMessage(quickfix.fix44.NewOrderSingle order, SessionID sessionID)
360360

361361
if (isOrderExecutable(order, price)) {
362362
quickfix.fix44.ExecutionReport executionReport = new quickfix.fix44.ExecutionReport(genOrderID(),
363-
genExecID(), new ExecType(ExecType.FILL), new OrdStatus(OrdStatus.FILLED), order.getSide(),
363+
genExecID(), new ExecType(ExecType.TRADE), new OrdStatus(OrdStatus.FILLED), order.getSide(),
364364
new LeavesQty(0), new CumQty(orderQty.getValue()), new AvgPx(price.getValue()));
365365

366366
executionReport.set(order.getClOrdID());
@@ -385,7 +385,7 @@ public void onMessage(quickfix.fix50.NewOrderSingle order, SessionID sessionID)
385385
Price price = getPrice(order);
386386

387387
quickfix.fix50.ExecutionReport accept = new quickfix.fix50.ExecutionReport(
388-
genOrderID(), genExecID(), new ExecType(ExecType.FILL), new OrdStatus(
388+
genOrderID(), genExecID(), new ExecType(ExecType.NEW), new OrdStatus(
389389
OrdStatus.NEW), order.getSide(), new LeavesQty(order.getOrderQty()
390390
.getValue()), new CumQty(0));
391391

@@ -395,7 +395,7 @@ public void onMessage(quickfix.fix50.NewOrderSingle order, SessionID sessionID)
395395

396396
if (isOrderExecutable(order, price)) {
397397
quickfix.fix50.ExecutionReport executionReport = new quickfix.fix50.ExecutionReport(
398-
genOrderID(), genExecID(), new ExecType(ExecType.FILL), new OrdStatus(
398+
genOrderID(), genExecID(), new ExecType(ExecType.TRADE), new OrdStatus(
399399
OrdStatus.FILLED), order.getSide(), new LeavesQty(0), new CumQty(
400400
orderQty.getValue()));
401401

0 commit comments

Comments
 (0)