From 937c2e89e718dbfe9fc962521c723ff07ddca1c8 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Sat, 24 May 2025 18:28:17 +0200 Subject: [PATCH 1/6] Generate javadoc for nightly build --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 9598021b5..fda6f49ac 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -24,7 +24,7 @@ jobs: cache: maven - name: Build SNAPSHOT - run: ./mvnw clean package -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw clean package -B -V -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - name: Delete old packages continue-on-error: true From ee15673611f0de623f6b3dd4a879dc2f41502135 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Mon, 26 May 2025 14:21:30 +0200 Subject: [PATCH 2/6] Ignore javadoc errors --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index fda6f49ac..adac784f6 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -24,7 +24,7 @@ jobs: cache: maven - name: Build SNAPSHOT - run: ./mvnw clean package -B -V -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw clean package -B -V -Xdoclint:none -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - name: Delete old packages continue-on-error: true From ed863ecd89f0269890bd5828f7d103aa9249e191 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Mon, 26 May 2025 18:56:35 +0200 Subject: [PATCH 3/6] Update nightly-build.yml --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index adac784f6..c1d923e65 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -24,7 +24,7 @@ jobs: cache: maven - name: Build SNAPSHOT - run: ./mvnw clean package -B -V -Xdoclint:none -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw clean package -B -V -D"Xdoclint:none" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - name: Delete old packages continue-on-error: true From 6993a20ef66a01bb5e754cb7ec0bc3f816b62ca0 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Tue, 3 Jun 2025 11:06:35 +0200 Subject: [PATCH 4/6] try JDK17 .... to check for javadoc errors --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index c1d923e65..4bfa64ce5 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -20,7 +20,7 @@ jobs: uses: actions/setup-java@v4 with: distribution: temurin - java-version: 21 + java-version: 17 cache: maven - name: Build SNAPSHOT From 9d128f7ce3f931b7ca18d599c69225a840e859cb Mon Sep 17 00:00:00 2001 From: Christoph John Date: Tue, 3 Jun 2025 11:52:30 +0200 Subject: [PATCH 5/6] exclude quickfixj-distribution ... mainly because of javadoc errors, but on the other hand it shouldn't be needed --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 4bfa64ce5..15aeb1d77 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -24,7 +24,7 @@ jobs: cache: maven - name: Build SNAPSHOT - run: ./mvnw clean package -B -V -D"Xdoclint:none" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw clean package -pl '!quickfixj-distribution' -B -V -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - name: Delete old packages continue-on-error: true From b4636809565fc6ecd8f6caaf92cebb438bde885d Mon Sep 17 00:00:00 2001 From: Christoph John Date: Tue, 3 Jun 2025 19:00:38 +0200 Subject: [PATCH 6/6] try to skip install step on deploy --- .github/workflows/nightly-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 15aeb1d77..f348b80d1 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -24,7 +24,7 @@ jobs: cache: maven - name: Build SNAPSHOT - run: ./mvnw clean package -pl '!quickfixj-distribution' -B -V -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw clean install -pl '!quickfixj-distribution' -B -V -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - name: Delete old packages continue-on-error: true @@ -62,6 +62,6 @@ jobs: org.quickfixj.quickfixj-perf-test - name: Deploy SNAPSHOT - run: ./mvnw deploy -B -V -DskipTests -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw deploy -B -V -Dmaven.install.skip=true -DskipTests -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}