Skip to content

[Junie]: feat: add AllocAcctIDSource values for consistency #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jetbrains-junie[bot]
Copy link
Contributor

@jetbrains-junie jetbrains-junie bot commented Jul 3, 2025

Fixes #377

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary

Enumerated values for field 661 (AllocAcctIDSource) were successfully added to various FIX data dictionary files (including FIX44, FIX50, FIX50SP1, FIX50SP2) to match those of field 660 (AcctIDSource) for consistency. Despite encountering build errors preventing tests from running, the changes were deemed minimal and necessary according to FIXimate documentation, leading to the patch submission.

 Enumerated values for field 661 (AllocAcctIDSource) were successfully added to various FIX data dictionary files (including FIX44, FIX50, FIX50SP1, FIX50SP2) to match those of field 660 (AcctIDSource) for consistency. Despite encountering build errors preventing tests from running, the changes were deemed minimal and necessary according to FIXimate documentation, leading to the patch submission.
@jetbrains-junie jetbrains-junie bot added the junie label Jul 3, 2025
@chrjohn
Copy link
Member

chrjohn commented Jul 3, 2025

@jetbrains-junie, oh no, RepeatingGroupTest.testIgnoreOutOfOrderGroupMembers is failing now. Could you please adapt the test?

Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

The test `RepeatingGroupTest.testIgnoreOutOfOrderGroupMembers` was failing due to invalid values for field 661 (AllocAcctIDSource), which were updated to valid enumerated values "1" (BIC) and "2" (SID_CODE). The build encountered errors, preventing the test from running, leaving the outcome unresolved. The changes made should fix the test if build issues are resolved.
Copy link
Contributor Author

✅ Generation Status

  • Code generation was successful

Message:

The test RepeatingGroupTest.testIgnoreOutOfOrderGroupMembers was failing due to invalid values for field 661 (AllocAcctIDSource), which were updated to valid enumerated values "1" (BIC) and "2" (SID_CODE). The build encountered errors, preventing the test from running, leaving the outcome unresolved. The changes made should fix the test if build issues are resolved.


📌 Issues Detected During Processing

  • Some issues occurred that may have limited the context available during generation.
  • These did not prevent the operation, but fixing them could improve the results.

Message:

I tried to build the project before getting started, but it didn’t work.

There might be issues with the environment or the code itself. Please check build log for more details.

More information:

@chrjohn
Copy link
Member

chrjohn commented Jul 3, 2025

Closing and reopening to have github actions pick this up...

@chrjohn chrjohn closed this Jul 3, 2025
@chrjohn chrjohn reopened this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

661/AllocAcctIDSource lacks enumerated values in data dictionaries and generated code
1 participant