Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

China's population has multiple numbers #48

Open
cmilousi opened this issue Jan 13, 2021 · 3 comments
Open

China's population has multiple numbers #48

cmilousi opened this issue Jan 13, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cmilousi
Copy link

When I scroll to China and while I am inside China's box, it shows a lot of different numbers of population when there should only be one number referring to China's population.

Screen Recording:
(URL : https://www.dropbox.com/s/bsty0kfhu9l8qrr/20210111_133818~2.mp4?dl=0)
This issue in depicted in the video from 0:09 to the end.

Sorry for the multiple issue creations. At first I wrote this issue in the same together with #47 but as they are not refered to the same problem I thought it was better to separate them.

I have experimented a lot with your app and I'm also trying to contribute with the grid layout for one of previous comments and I came up with this issue as well as #47 . Hope these help to make some improvement !

@shahsurajk
Copy link
Contributor

@cmilousi always happy to have contributions to the project.

on the multiple numbers issue, i think, it would be a good idea to highlight the selected item in the sample. from the screen record, what i can make out is that as you move the fast scroller the adapter moves the selected item too.

@shahsurajk
Copy link
Contributor

i think we should first update the example and highlight the selected element, use the callbacks provided here

@shahsurajk shahsurajk added enhancement New feature or request good first issue Good for newcomers labels Jan 13, 2021
@cmilousi
Copy link
Author

@shahsurajk to be more specific at 0:14 you can see that as I scroll but still remain in China the population goes from
1.3B -> 1.0B -> 278.4M -> 237.6M -> 170.1M -> 156.5M -> 146.9M -> 129.2M -> 126.7M and at 111.5M it switches to India.

Also , sorry I didnt quite catch where should I use these callbacks?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants