Skip to content

Fix flaky cache test #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hadley merged 1 commit into from
Oct 24, 2024
Merged

Fix flaky cache test #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/testthat/test-req-perform.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ test_that("can cache requests with etags", {

test_that("can cache requests with paths (cache-control)", {
req <- request(example_url()) %>%
req_url_path("/cache/1") %>%
req_url_path("/cache/2") %>%
req_cache(withr::local_tempfile())

path1 <- withr::local_tempfile()
Expand All @@ -132,7 +132,11 @@ test_that("can cache requests with paths (cache-control)", {
)
expect_equal(resp2$body[[1]], path2)

Sys.sleep(1.1) # wait for cache to expire
# Wait until cache expires
cached_resp <- cache_get(req)
info <- resp_cache_info(cached_resp)
Sys.sleep(max(as.double(info$expires - Sys.time()), 0))

path3 <- withr::local_tempfile()
expect_condition(
resp3 <- req %>% req_perform(path = path3),
Expand Down