Fix gcc-8 catch-value warnings

jimhester · jimhester · commit 1e34212b2e35 · 2018-10-12T14:03:28.000-04:00
warning: catching polymorphic type 'class std::exception' by value [-Wcatch-value=]
warning: catching polymorphic type 'class std::logic_error' by value [-Wcatch-value=]
diff --git a/src/test-catch.cpp b/src/test-catch.cpp
@@ -53,8 +53,8 @@ context("Exception handling") {
   test_that("we can use Catch to test for exceptions") {
 
     expect_error(ouch());
-    expect_error_as(ouch(), std::exception);
-    expect_error_as(ouch(), std::logic_error);
+    expect_error_as(ouch(), std::exception&);
+    expect_error_as(ouch(), std::logic_error&);
 
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ context("Exception handling") {`
`53`	`53`	`test_that("we can use Catch to test for exceptions") {`
`54`	`54`
`55`	`55`	`expect_error(ouch());`
`56`		`- expect_error_as(ouch(), std::exception);`
`57`		`- expect_error_as(ouch(), std::logic_error);`
	`56`	`+ expect_error_as(ouch(), std::exception&);`
	`57`	`+ expect_error_as(ouch(), std::logic_error&);`
`58`	`58`
`59`	`59`	`}`
`60`	`60`	`}`