Wrong `snapshot_accept()` suggestion if period in test file name

[moodymudskipper]

I have a test file called "test-data.frame.R" (notice there are 2 periods in full name)

When running tests with a new output I get the suggestion to run snapshot_accept("data.frame")

When I run it however I get "No snapshots to update"

This is due to testthat:::snapshot_meta where we find :

files <- ifelse(tools::file_ext(files) == "", paste0(files, ".md"))

There "frame" is returned by tools::file_ext() so no suffix is added.

A solution might be to have :

files <- ifelse(tools::file_ext(files) != "md", paste0(files, ".md")

Another solution would be to manage to have the suggestion be snapshot_accept("data.frame.md")

[d-morrison]

I ran into the same issue; here's a reprex: https://github.com/d-morrison/testthat.suffix.issue

[d-morrison]

snapshot_accept() (with no arguments) is a possible workaround (but it accepts changes for all snapshots).

[hadley]

Thinking through what's happening in snapshot_meta(). There are four paths that a snapshot can generate: it can either be from expect_snapshot() or expect_snapshot_file() and it can be either with or without a variant:

# expect_snapshot()
"_snap/test.md"
"_snap/variant/test.md"
# expect_snapshot_file()
"_snap/test/file.txt"
"_snap/variant/test/file.txt"

There's some confusion because we can't know for sure if "_snap/variant/test.md" is from expect_snapshot() with a variant or expect_snapshot_file() from test file test-variant.R with file name test.md. But snapshot_meta() doesn't seem to acknowledge the existence of variants at all.

[hadley]

Oh, but that's not actually the problem at hand here (although we still might want to consider it). The problem is that snapshot_accept() can take either foo or foo.md, so I think maybe we could just do files <- c(files, paste0(files, ".md"))