More tests of running a nested subtest #2203
Conversation
| }) | ||
|
|
||
| test_that("only returns code before subtest", { | ||
| test_that("only returns non-subtest code before subtest", { |
There was a problem hiding this comment.
This seemed worth testing to me, i.e. making sure that the test_that() is not retained.
| ) | ||
| }) | ||
|
|
||
| test_that("works on code like the describe() example", { |
There was a problem hiding this comment.
More pretty realistic usage that seems worth testing.
| filter_desc(code, c("math library", "division()", "can handle division by 0")) | ||
| Condition | ||
| Error: | ||
| ! Failed to find test with description "can handle division by 0". |
There was a problem hiding this comment.
Just an FYI: the (nested) desc that identifies the targeted it() is c("math library", "division()", "can handle division by 0"). But we only mention the last component here.
| #' @param desc A character vector used to filter tests. This is used to | ||
| #' (recursively) filter the content of the file, so that only the non-test | ||
| #' code up to and including the match test is run. | ||
| #' code up to and including the matching test is run. |
There was a problem hiding this comment.
This documentation only applies to source_file() which is marked as internal.
The user-facing function(s?) that expose desc do not yet hint at the ability to run a nested subtest or to run an it(). I know this applies to test_file() and perhaps that is the only affected function.
|
Thanks! |
Consider this late-arriving review comments on #2077
I'll make a few comments inline.