In CheckReporter, only display snapshot messaging once

[hadley]

It's not actionable since you can't click, so no reason not to show once at the end.

[hadley]

@claude take a stab at this. You'll need to suppress the default per-snapshot hints, and instead have one hint at the end of the check reporter (which will need some way to track if any snapshots failed). This hint will need to suggest snapshot_accept() and snapshot_reject() without any arguments in order to process all snapshots at once.

[claude]

Claude finished @hadley's task —— View job • claude/issue-2207-20250812-2256 • Create PR ➔

---

Tasks

• Analyze current CheckReporter implementation
• Find where snapshot hints are currently displayed
• Modify CheckReporter to track snapshot failures
• Suppress per-snapshot hints in CheckReporter
• Add single hint at end when snapshots fail
• Test the implementation
• Run formatting/linting commands
• Commit and push changes

Implementation Complete ✅

I've successfully implemented the requested feature to display snapshot messaging only once in CheckReporter. Here's what was changed:

Changes Made:

1. Modified CheckReporter (R/reporter-check.R):

   • Added has_snapshot_failures field to track when snapshot failures occur
   • Enhanced add_result() to detect snapshot failures by checking for "Snapshot of .* has changed" message pattern
   • Added summary hint in end_reporter() method that suggests using snapshot_accept() and snapshot_reject() without arguments

2. Modified snapshot hint logic (R/snapshot.R):

   • Updated expect_snapshot_helper() to check if CheckReporter is active
   • Suppresses individual per-snapshot hints when CheckReporter is being used
   • Preserves original behavior for other reporters

Key Features:

• ✅ Suppresses non-actionable per-snapshot hints in CheckReporter
• ✅ Displays single consolidated hint at end of test run
• ✅ Suggests snapshot_accept() and snapshot_reject() without arguments for batch processing
• ✅ Only affects CheckReporter - other reporters maintain existing behavior
• ✅ Backwards compatible implementation

Technical Details:

• Uses pattern matching on failure messages to detect snapshot failures
• Leverages existing get_reporter() mechanism to detect CheckReporter context
• Clean separation of concerns - CheckReporter tracks failures, snapshot system respects reporter choice

[hadley]

@claude the snapshot should report that it failed, rather than relying on a regular expression.

[claude]

Claude finished @hadley's task —— View job • claude/issue-2207-20250813-1224 • [Create PR ➔](https://github.com/r-lib/testthat/compare/main...claude/issue-2207-20250813-1224?quick_pull=1&title=Issue%20%232207%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%232207%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

---

Implementation Complete ✅

I've successfully modified the implementation to have snapshots directly report failures instead of using regex matching.

Tasks

• Analyze current snapshot failure reporting mechanism
• Create expectation_snapshot_failure subclass
• Modify snapshot system to use snapshot failure subclass
• Modify CheckReporter to detect snapshot failures directly
• Test the implementation
• Run formatting/linting commands
• Commit and push changes

Changes Made

Created Direct Failure Reporting:

1. Added expectation_snapshot_failure subclass (R/expect-that.R, R/expectation.R):

   • Created specialized fail_snapshot() function that creates expectation objects with expectation_snapshot_failure subclass
   • Added expectation_snapshot_failure() helper function to detect these specialized failures

2. Modified Snapshot System (R/snapshot.R, R/snapshot-file.R, R/snapshot-reporter.R):

   • Updated all snapshot failure paths to use fail_snapshot() instead of fail()
   • Snapshots now directly report their failure status through the type system

3. Enhanced CheckReporter (R/reporter-check.R):

   • Added has_snapshot_failures field to track when snapshot failures occur
   • Modified add_result() to detect expectation_snapshot_failure instances
   • Added summary hint in end_reporter() suggesting snapshot_accept() and snapshot_reject() without arguments

4. Suppressed Individual Hints:

   • Updated snapshot systems to detect when CheckReporter is active
   • Individual per-snapshot hints are suppressed only for CheckReporter
   • Other reporters maintain existing behavior with individual hints

Technical Benefits

• ✅ No regex matching - Uses proper type system for failure detection
• ✅ Direct reporting - Snapshots communicate failure status explicitly
• ✅ Clean architecture - Separation of concerns between failure detection and reporting
• ✅ Backwards compatible - Only affects CheckReporter behavior
• ✅ Consolidated messaging - Single actionable hint instead of multiple non-actionable ones