Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Aug 14, 2025

@d-morrison does this seem more clear to you?

@claude
Copy link

claude bot commented Aug 14, 2025

Claude finished @hadley's task —— View job


Reviewing documentation changes

  • Read modified R/snapshot-file.R to understand documentation changes
  • Read modified man/expect_snapshot_file.Rd to review generated docs
  • Analyze changes for technical accuracy and clarity issues
  • Provide review feedback

Issues Found

Typo in example code at R/snapshot-file.R:58:

expect_snasphot_file(save_file(path, mydata()), "data.txt")

Should be:

expect_snapshot_file(save_file(path, mydata()), "data.txt")

Minor grammar issue at R/snapshot-file.R:46:

if youres test is conditionally executed

Should be:

if your test is conditionally executed

Copy link

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadley yes, much more clear - thanks!

hadley and others added 2 commits August 14, 2025 16:02
Co-authored-by: Douglas Ezra Morrison <demorrison@ucdavis.edu>
@hadley hadley merged commit fcc9f87 into main Aug 15, 2025
13 checks passed
@hadley hadley deleted the announce-file-docs branch August 15, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants