Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Oct 6, 2025

No description provided.

@claude
Copy link

claude bot commented Oct 6, 2025

Claude finished @hadley's task —— View job


Reviewing PR: Apply check_vector() to evaluated value

  • Read and analyze the modified file
  • Check for potential bugs or issues
  • Provide review feedback

Review Findings

The changes look correct. The PR fixes a bug where check_vector() was being called on the unevaluated expressions (object and expected) instead of their evaluated values (act$val and exp$val).

Key improvements:

  • expect_contains() and expect_in() now properly validate the evaluated values
  • Consistent with expect_setequal() which already had this correct pattern (lines 31-32)
  • check_vector() function signature simplified by removing caller_arg(x) default

The fix ensures error messages will correctly identify the problematic argument by passing explicit error_arg parameters.

LGTM

@hadley hadley merged commit 8dcf1e2 into main Oct 6, 2025
14 checks passed
@hadley hadley deleted the check-vector-quasi branch October 6, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant