Overhaul expect_matches()
#2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `expect_snapshot_failure()` to look at more of the messaging, and then use that to make a bunch of minor improvements.
krlmlr
approved these changes
Jul 30, 2025
Comment on lines
+42
to
+47
| check_character(object) | ||
| check_string(regexp) | ||
| check_bool(perl) | ||
| check_bool(fixed) | ||
| check_bool(all) | ||
|
|
There was a problem hiding this comment.
labelis likely checked above byquasi_label(), do we want to checkinfo? It's still used in the empty case below.- Do you want to take this as an opportunity to add a
grepl_args = list()(or= NULL) argument and soft-deprecate...(with a lifecycle warning)?
There was a problem hiding this comment.
I don't care that much about info since we're phasing it out in new expectations.
I don't want to do any bigger refactorings because if I did I'd really want to stop it from being vectorising and instead make it work with a single string; but that's going to break a bunch of tests.
There was a problem hiding this comment.
Could we use the all argument for enforcing a scalar? all = NA or all = "scalar" would mean to expect a scalar, with a lifecycle warning to add all = TRUE if a non-scalar is provided without setting all ?
There was a problem hiding this comment.
I don't think it's important enough to do all that work.
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
expect_snapshot_failure()to look at more of the messaging, and then use that to make a bunch of minor improvements.Fixes #2135