Feature: expose srcref of tests in reporters #2220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubajal
force-pushed
the
feature/expose_srcref_in_start_test
branch
from
4be00d6 to
96489ce
Compare
kubajal
force-pushed
the
feature/expose_srcref_in_start_test
branch
3 times, most recently
from
817eb5c to
2ee85c7
Compare
|
@hadley any chance of this getting merged? |
|
I've fixed the style issue, re-used the srcref standard display, and added a test specifically for nested tests. But this PR introduces some confusion because |
|
I've thought it over a bit more, and it doesn't feel like a good fit for testthat to me. I've done most of the work to make it maintainable for me over the long term, but it still feels a bit fragile and I'm not fully sold on the motivation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to report the line number of tests in reporters. This PR enables that.
This PR follows the logic of e.g. LocationReporter which prints the srcref of all
expect_*assertions. It extends this behavior by also reporting locations oftest_that,describeanditexpressions.With minimal effort, this PR enables #2184.