Incorporate doc feedback from @maelle #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Claude finished @hadley's task —— View job Code Review CompleteReviewing PR changes for potential bugs or issues:
Issues found:
LGTM for all other changes - documentation improvements, vignette references to |
maelle
reviewed
Sep 9, 2025
vignettes/custom-expectation.Rmd
Outdated
|
|
||
| ## Do you need it? | ||
|
|
||
| But before you read the rest of the vignette and dive into the full details of creating a fully 100% correct expectation, consider if you can get away with a simpler wrapper. For example, take this expectation from tidytext: |
There was a problem hiding this comment.
why not start with an example of a wrapper that is fine? For instance it could be
expect_df <- function(tbl) {
expect_s3_class(tbl, "data.frame")
}Or here is a real example: https://github.com/ropensci/aorsf/blob/2b7fa72bff5cd4e8b2984358e35d0938e50540b0/tests/testthat/helper-orsf.R#L259
mcol
reviewed
Sep 9, 2025
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Marco Colombo <mar.colombo13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.