Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Sep 9, 2025

No description provided.

@claude
Copy link

claude bot commented Sep 9, 2025

Claude finished @hadley's task —— View job


Reviewing PR: Revdeps 2025-09

Todo List:

  • Read and analyze changed revdep files
  • Check for concerning patterns or regressions
  • Provide minimal feedback on bugs/issues

Critical Issue Identified:

Multiple packages are failing because is_true is no longer exported from testthat namespace. This appears to be a breaking change that affects many reverse dependencies.

Example failure:

Error: 'is_true' is not an exported object from 'namespace:testthat'

This pattern appears across numerous packages including bgmfiles, and likely explains many of the 128 new test failures.

Recommendation: This breaking change needs to be addressed before release, either by:

  1. Re-exporting is_true
  2. Adding deprecation warnings instead of immediate removal
  3. Documenting the breaking change in NEWS

The scope of impact (128 packages) suggests this change may be too disruptive for a minor release.

@hadley hadley merged commit 0ff28c7 into main Sep 29, 2025
11 checks passed
@hadley hadley deleted the revdeps-2025-09 branch September 29, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants