Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Sep 30, 2025

No description provided.

@claude
Copy link

claude bot commented Sep 30, 2025

Claude finished @hadley's task —— View job


PR Review

Tasks

  • Read and analyze the modified files
  • Review code changes for potential bugs or issues
  • Provide minimal technical feedback

Review

The changes look correct. The fix properly handles missing arguments in labelled_value() by checking missing(value) and returning missing_arg() when appropriate, rather than trying to store the missing value directly in a list.

The test coverage is adequate - it verifies that missing arguments are properly propagated through the expectation system.

LGTM

@hadley hadley merged commit 39de8d1 into main Sep 30, 2025
14 checks passed
@hadley hadley deleted the absent-input branch September 30, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant