-
Notifications
You must be signed in to change notification settings - Fork 340
Implement expect_all_equal() and friends
#2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @hadley's task —— View job Code Review
AnalysisThe PR introduces
The refactoring of LGTM. |
| @@ -0,0 +1,67 @@ | |||
| #' Do you expect every value in a vector to have this value? | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #' Do you expect every value in a vector to have this value? | |
| #' Does a vector have a constant value? |
Just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constant makes me think unchanging (over time)
| expect_all_equal(x, TRUE) | ||
| Condition | ||
| Error: | ||
| ! Expected every element of `x` to equal TRUE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ! Expected every element of `x` to equal TRUE. | |
| ! Expected every element of `x` to equal `TRUE`. |
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW that would be inconsistent with expect_equal().
expect_all_equal()expect_all_equal() and friends
Fixes #1836. Fixes #2235. Closes #2240.