Skip to content

Commit e348ffc

Browse files
author
DanielePalaia
committed
making exchange arguments optional
1 parent 8553249 commit e348ffc

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

examples/getting_started/basic_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def main() -> None:
9393
management = connection.management()
9494

9595
print("declaring exchange and queue")
96-
management.declare_exchange(ExchangeSpecification(name=exchange_name, arguments={}))
96+
management.declare_exchange(ExchangeSpecification(name=exchange_name))
9797

9898
management.declare_queue(
9999
QuorumQueueSpecification(name=queue_name)

examples/getting_started/reconnection_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def main() -> None:
150150

151151
print("declaring exchange and queue")
152152
connection_configuration.management.declare_exchange(
153-
ExchangeSpecification(name=exchange_name, arguments={})
153+
ExchangeSpecification(name=exchange_name)
154154
)
155155

156156
connection_configuration.management.declare_queue(

examples/getting_started/tls_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def main() -> None:
9393
management = connection.management()
9494

9595
print("declaring exchange and queue")
96-
management.declare_exchange(ExchangeSpecification(name=exchange_name, arguments={}))
96+
management.declare_exchange(ExchangeSpecification(name=exchange_name))
9797

9898
management.declare_queue(
9999
QuorumQueueSpecification(name=queue_name)

rabbitmq_amqp_python_client/entities.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from dataclasses import dataclass
1+
from dataclasses import dataclass, field
22
from enum import Enum
33
from typing import Any, Dict, Optional, Union
44

@@ -13,7 +13,7 @@
1313
@dataclass
1414
class ExchangeSpecification:
1515
name: str
16-
arguments: dict[str, str]
16+
arguments: dict[str, str] = field(default_factory=dict)
1717
exchange_type: ExchangeType = ExchangeType.direct
1818
is_auto_delete: bool = False
1919
is_internal: bool = False
@@ -24,7 +24,7 @@ class ExchangeSpecification:
2424
class QueueInfo:
2525
name: str
2626
arguments: dict[str, Any]
27-
queue_type: QueueType = QueueType.quorum
27+
queue_type: QueueType = QueueType.classic
2828
is_exclusive: Optional[bool] = None
2929
is_auto_delete: bool = False
3030
is_durable: bool = True

tests/test_management.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_declare_delete_exchange(management: Management) -> None:
1717
exchange_name = "test-exchange"
1818

1919
exchange_info = management.declare_exchange(
20-
ExchangeSpecification(name=exchange_name, arguments={})
20+
ExchangeSpecification(name=exchange_name)
2121
)
2222

2323
assert exchange_info.name == exchange_name
@@ -43,7 +43,7 @@ def test_bind_exchange_to_queue(management: Management) -> None:
4343
queue_name = "test-bind-exchange-to-queue-queue"
4444
routing_key = "routing-key"
4545

46-
management.declare_exchange(ExchangeSpecification(name=exchange_name, arguments={}))
46+
management.declare_exchange(ExchangeSpecification(name=exchange_name))
4747

4848
management.declare_queue(QuorumQueueSpecification(name=queue_name))
4949

tests/test_publisher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def test_publish_exchange(connection: Connection) -> None:
9797
management = connection.management()
9898
routing_key = "routing-key"
9999

100-
management.declare_exchange(ExchangeSpecification(name=exchange_name, arguments={}))
100+
management.declare_exchange(ExchangeSpecification(name=exchange_name))
101101

102102
management.declare_queue(QuorumQueueSpecification(name=queue_name))
103103

0 commit comments

Comments
 (0)