Skip to content

Streams support and management of disconnections #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Feb 3, 2025

This closes #26
This closes #25

It adds support for consuming streams on different offsets and supports filters too.

Example is provided in ./examples/getting_started/example_with_streams

It include also #25 so maybe we can just review and test this branch

@DanielePalaia DanielePalaia marked this pull request as draft February 3, 2025 14:17
DanielePalaia and others added 2 commits February 4, 2025 09:31
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@DanielePalaia DanielePalaia force-pushed the streams_support branch 2 times, most recently from a32388b to 4207695 Compare February 4, 2025 13:51
@DanielePalaia DanielePalaia changed the title DRAFT: Streams support Streams support Feb 5, 2025
@DanielePalaia DanielePalaia marked this pull request as ready for review February 5, 2025 08:36
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the example but for it is ok

for i in range(messages_to_publish):

if i % 1000 == 0:
print("publishing 1000 messages...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print("published <<i>> messages...")

@DanielePalaia DanielePalaia changed the title Streams support Streams support and management of disconnections Feb 5, 2025
@DanielePalaia DanielePalaia merged commit d08139f into main Feb 5, 2025
1 check passed
@DanielePalaia DanielePalaia deleted the streams_support branch February 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement full Stream support for Consumer
2 participants