Switch from pg_local to pg #14825
Draft
Switch from pg_local to pg #14825
+123
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
force-pushed
the
remove-pg_local
branch
2 times, most recently
from
7998fc2 to
669513b
Compare
mkuratczyk
force-pushed
the
remove-pg_local
branch
from
669513b to
c4bba00
Compare
|
To add a bit of context here. Process groups can be used in many ways but specifically in RabbitMQ they were used for tracking of exclusive queues on an AMQP 0-9-1 connection, so that when a connection terminates, all exclusive queues (if any) on it would be terminated very shortly after. RabbitMQ Stream Protocol does not allow clients to declare exclusive streams, so it likely can avoid using process groups entirely. And so can most protocol readers. |
mkuratczyk
force-pushed
the
remove-pg_local
branch
from
c4bba00 to
4292012
Compare
This function was not called from anywhere and was the only place that expected stream connections to be registered in pg_local.
pg_local is based on the pg2 module, which got removed from Erlang/OTP years ago. It was replaced by the more efficient pg module, so let's use it directly. We use node-local scopes and single-item groups so that (de)registration is fast, but we can list all connections/channels (by listing all groups in the scope).
These values don't chnage at runtime and take a surprising amount of resources when opening a lot of connections. This speeds up opening many connections/channels by 10% in my tests.
mkuratczyk
force-pushed
the
remove-pg_local
branch
from
4292012 to
b88adbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_local is based on the pg2 module, which got removed
from Erlang/OTP years ago. It was replaced by the more
efficient pg module, so let's use it directly.
We use node-local scopes and single-item groups so that
(de)registration is fast, but we can list all connections/channels
(by listing all groups in the scope).