Skip to content

internal: Fixed the cluster status cannot be changed after the POD ex… #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2022
Merged

internal: Fixed the cluster status cannot be changed after the POD ex… #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/http_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ limitations under the License.
package internal

import (
"context"
"fmt"
"io"
"net/http"
"time"
)

type Request struct {
Expand Down Expand Up @@ -63,7 +65,11 @@ func NewHttpExecutor(httpClient HttpClient) Executor {
}

func (executor *httpExecutor) Execute(req *Request) (*Response, error) {
resp, err := executor.Client.Do(req.Req)
// Add timeout to prevent access from not existing POD, this will cause the program to block.
// https://github.com/radondb/radondb-mysql-kubernetes/issues/353
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
resp, err := executor.Client.Do(req.Req.WithContext(ctx))
if err != nil {
return nil, err
}
Expand Down