Overload rechunk from DiskArrays #940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
reviewed
Feb 27, 2025
ext/DimensionalDataDiskArraysExt.jl
Outdated
| @@ -17,6 +17,15 @@ import DiskArrays | |||
| modify(A -> DiskArrays.cache(A; kw...), x) | |||
| end | |||
|
|
|||
| @static if isdefined(DiskArrays, :isdisk) | |||
| DiskArrays.isdisk(dd::AbstractDimArray) = DiskArrays.isdisk(parent(dd)) | |||
There was a problem hiding this comment.
Should isdisk on a stack check any(isdisk, layers(stack))?
rafaqz
changed the title
|
bump @felixcremer (at least on the stack bit, looks like that PR is still frozen and something we should address on Thursday / Wednesday) |
|
Reopen when the name is resolve in DiskArrays.jl |
* add DimTree object * tests * extent * add indexing * working trees * test branch differences * fix constructors * fix ambiguities * add DimTree to api docs
* add lazypermutedims and specialise for disk arrays * add tests * cleanup
* start to fix dimnum * Test reducing functions for dims not in array * fix empty tuple case * bugfix dimnum * bugfix reductions
* fix accidental piracy from empty splat in map * Fix stack map piracy
* Use DimArray with X and Y coordinate for Begin End index docs * Add some tests for Begin and End * Add tests for show and some indexing for BeginEndRanges * Add show test for BeginEndStepRange * Add broken test for (End \div 2) +1 * Add test for Lazymath of Fix1 * Fix print of 1+Begin and test nested show * Allow max and min with Begin End * Fix div(End,2)+1 indexing * Update src/Lookups/beginend.jl * Update src/Lookups/beginend.jl * Update src/Lookups/beginend.jl Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com> * Add more tests * Fix show of Composed function * Fix show for Begin End * Test show of max and min * Add whitespace in max, min show test cases * Add test for Fix1 with constructed Begin * Remove unused _print_f method --------- Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com>
* use maplayers in (un)mergedims * test unmergedims on a dimstack
…z#971) Previously the code would temporarily store the dimension => lookup mapping in a Dict, but that doesn't maintain insertion order. So later on it was possible for the DimArray to be created with the dimensions in the wrong order, which would cause an exception.
…afaqz#972) * Add support for zero-copy conversions from an xarray to a DimArray * Add precompilation statements for the PythonCall extension * Attempt to fix OpenSSL compat issues in CI If PythonCall installed a version of OpenSSL incompatible with what Julia is built with and it loads the newer version first, that will conflict with any other Julia package (e.g Plots.jl) that tries to load OpenSSL afterwards. Here we hack around that by just loading OpenSSL.jl first so that Python uses that.
* Fix missing Colorbar in heatmap * Add Colorbar tests * Remove Makie dependency
* update and test DimStack constructors * capital * Apply suggestions from code review Co-authored-by: Tiem van der Deure <tiemvanderdeure@gmail.com> * Tuple and bugfix * document maplayers * more tests * typo --------- Co-authored-by: Tiem van der Deure <tiemvanderdeure@gmail.com>
* fix d macro infix assignment * cleanup
The functionality there seems to be moved to dimension.jl
This seems to not be needed anymore.
* RUn JET and bugfix * fix ambiguities * dont force type * jet * dont doc
* fix makie axis keywords * bugfix tests and test colorbar kw * remove comment
* clean up show * tweak array show * dimcolor
* construct dimensions before concatenating stack layers * ups for DVPress 0.2 * wanrnonly due to broken doctests * doctest false * fix print of dimgroupbyarray * update docstrings using `doctest(DD; fix = true)` * revert commit from different PR (oops) * construct dimensions before concatenating stack layers * fix print of dimgroupbyarray * update docstrings using `doctest(DD; fix = true)` * revert commit from different PR (oops) * no false * drop `Dates.` in docstrings * link to integrations --------- Co-authored-by: tiemvanderdeure <tiemvanderdeure@gmail.com>
release a new tag
…ting compat) (rafaqz#1020) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
…, (keep existing compat) (rafaqz#1023) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
* Fix DimTree example block * Remove trailing comma
…z#1027) The information is in the type and does not require a name lookup to find Fix rafaqz#937
* change expand_dimensions to nothing, add MakieExt tests * add series test * lines works but observable on axis do not update * rewrote a lot. PointBased seem do work * series with labeldim * test for 1d plots done * add tests for 2d plots * improv test. New extension works for 1d, 2d, and 3d plots * add more tests and colorbars * fix bug on plot with Observable * new makie tests, change CairoMakie to 0.13, fix color handling on series * add support to GridPosition and similar * fix typo in makie test * clean Makie extension * reorder tests * various changes to work on all old tests * various changes on tests and minor MakieExt to work with Makie0.24 * fix to work with Makie <0.24 * fix SampledBased and labels on Series * relabel x_dim to xdim and categorical_dim to categoricaldim
|
I will open a new PR once a new Diskarrays version is tagged. I somehow messed up the git history on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on the corresponding PR from DiskArrays JuliaIO/DiskArrays.jl#237
This simply forwards the functions to the parent of the DimArray.