-
Notifications
You must be signed in to change notification settings - Fork 21.9k
[RF-DOCS] Sign up guide #55254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[RF-DOCS] Sign up guide #55254
Conversation
Co-authored-by: Amanda Perino <58528404+AmandaPerino@users.noreply.github.com>
Co-authored-by: Amanda Perino <58528404+AmandaPerino@users.noreply.github.com>
Co-authored-by: Amanda Perino <58528404+AmandaPerino@users.noreply.github.com>
@excid3 how does one get to this guide? Is it linked from the Getting Started one? |
@MatheusRich @excid3 It needs to be added to: |
There are design changes coming so it will be done in a separate PR. |
@MatheusRich @p8 Just like the /docs landing page we launched last year, we are building a Tutorial landing page where all of the tutorials, and all upcoming tutorials will live. (PR here.) |
@AmandaPerino amazing! For anyone reviewing and wants to preview the results:
![]()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial, as always @excid3! So easy to follow and yet very comprehensive! I love how clean the code is and all the little details you put here and there. It shows your deep understanding of the Rails-way. It teaches so much more than the title says. Well done!
@AmandaPerino That looks great! |
That makes sense to me for the new tutorials, but a little less clear how that would work with the Getting Started guide. It feels like the GS guide should stay in the guides.ror.org subdomain. But I'm open to differing thoughts here- is there any valid reason stopping it from also moving to /tutorials? If it stays on the subdomain, the navigation from that tutorial to the others feels less clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @excid3! Thank you for your continous contribution to the rails community!
Co-authored-by: Hartley McGuire <skipkayhil@gmail.com> Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
I can't imagine someone reading the "Getting Started" guide from Rails version 6.0. The use case for the "Getting Started" guide is a bit different than other guides. Most would probably read it once to build an app and never look at it again, whereas the other guides are used to look up things more often. The guides for older Rails version are useful when you are working on an application with that same version. So maybe it's a good idea to move that guide to /website as well? There are some existing guides which are more tutorial like. For example the plugins guide: https://guides.rubyonrails.org/plugins.html. I'm not sure those should be moved as well. |
Co-authored-by: Kyoungwon Lee (Stark) <kyoungwon.lee86@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great guide! Despite using Rails for years, I learned a few interesting things.
What do you think about inserting tests throughout the guide, after introducing new requirements and before showing code blocks? This could help foster a TDD/test-first culture among readers.
@MatheusRich I am trying to do just that, |
@MichaelGame-Dev the page has changed a little since i've last saw this, but you can find the docs link in the Annotations section: ![]() Click on Guides and add |
Co-authored-by: Jeremy BERTRAND <793603+NotGrm@users.noreply.github.com>
@excid3 Before this gets merged, could you wrap to 80 columns? |
@p8 done! |
Motivation / Background
This is a continuation of the Getting Started guide.
Detail
After building the e-commerce store, this guide adds:
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
cc @AmandaPerino