camel-cased column name causes sorting to fail

[gleenn]

We have a model with a unconventional camel-cased name "likeThis" instead of "like_this", when viewing a list of these models, and attempting to sort by that field, we get an exception from the database that that column doesn't exist because it appears to be looking for "likethis" (it looks downcased).

ActionView::Template::Error (PG::Error: ERROR: column our_table.likethis does not exist
2012-08-13T18:44:13+00:00 app[web.1]: LINE 1: SELECT "our_table".* FROM "our_table" ORDER BY our_table.likethi...
2012-08-13T18:44:13+00:00 app[web.1]: ^
2012-08-13T18:44:13+00:00 app[web.1]: : SELECT "our_table".* FROM "our_table" ORDER BY our_table.likeThis asc LIMIT 20 OFFSET 0):
2012-08-13T18:44:13+00:00 app[web.1]: 120: %tbody

...

2012-08-13T18:44:13+00:00 app[web.1]: 122: %tr
2012-08-13T18:44:13+00:00 app[web.1]: 123: %td
2012-08-13T18:44:13+00:00 app[web.1]: 124: = check_box_tag "bulk_ids[]", object.id, false
2012-08-13T18:44:13+00:00 app[web.1]: 125: - if @other_left_link ||= other_left && index_path(params.except('set').merge(params[:set].to_i != 1 ? {:set => (params[:set].to_i - 1)} : {}))
2012-08-13T18:44:13+00:00 app[web.1]: 126: %td.other.left= link_to "...", @other_left_link, :class => 'pjax'

[dexion]

sql case insensitive. just rename your model. I had same issue. I fix it by renaming model

[gleenn]

SQL is in fact quite case-sensitive.

Also, it's not the model name, its a column name issue. I renamed my column
as a work-around, however Rails does in fact allow you to have whatever
column and model names you want, Rails Admin shouldn't be assuming it can
downcase.

Thanks for being responsive, we really appreciate your work!

Glenn

On Mon, Aug 13, 2012 at 12:57 PM, Alexey notifications@github.com wrote:

sql case insensitive. just rename your model. I had same issue. I fix it
by renaming model

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1281#issuecomment-7705979.

[meghaarora42]

@mshibuya: We (@jayasi and I) want to start working on this. Let us know if you haven't taken it up already so that we can proceed with it!

[mshibuya]

@meghaarora42 Go ahead and try, please!

[meghaarora42]

@mshibuya: Thanks! :)

[geoffyoungs]

It's not a great solution - and I'm not clear from looking at the internals of RailsAdmin what the best way forward here is, but adding the following to my rails_admin initializer appears sufficient to work around this issue for now.

module RailsAdminColumnQuotePatch
  def build_statement_for_string_or_text
    original_column = @column
    @column = PG::Connection.quote_ident(original_column)
    begin
      super
    ensure
      @column = original_column
    end
  end

  def all(options = {}, scope = nil)
    if options[:sort].is_a?(String) && options[:sort] =~ /^[A-Za-z0-9_]+\.[A-Za-z0-9_]+$/
      table, column = options[:sort].split(/[.]/, 2)
      options[:sort] = [table, column].map { |name| PG::Connection.quote_ident(name) }.join('.')
    end
    super
  end
end

module RailsAdmin
  module Adapters
    module ActiveRecord
      prepend RailsAdminColumnQuotePatch
    end
  end
end