Improve SizeTraits for Integers

kidstell · kidstell · commit 810a063572a4 · 2020-08-09T02:01:58.000+01:00
Resolves #85 - Users can now validate min and max for integers with this update
diff --git a/src/Rules/Traits/SizeTrait.php b/src/Rules/Traits/SizeTrait.php
@@ -16,7 +16,7 @@ trait SizeTrait
     protected function getValueSize($value)
     {
         if ($this->getAttribute()
-            && $this->getAttribute()->hasRule('numeric')
+            && ($this->getAttribute()->hasRule('numeric') || $this->getAttribute()->hasRule('integer'))
             && is_numeric($value)
         ) {
             $value = (float) $value;

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ trait SizeTrait`
`16`	`16`	`protected function getValueSize($value)`
`17`	`17`	`{`
`18`	`18`	`if ($this->getAttribute()`
`19`		`- && $this->getAttribute()->hasRule('numeric')`
	`19`	`+ && ($this->getAttribute()->hasRule('numeric') \|\| $this->getAttribute()->hasRule('integer'))`
`20`	`20`	`&& is_numeric($value)`
`21`	`21`	`) {`
`22`	`22`	`$value = (float) $value;`