-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
I was looking at the code to understand how version.autoFetch
works, and I think there is a bug here:
sbt-git-versioning/src/main/scala/com/rallyhealth/sbt/versioning/GitFetcher.scala
Lines 24 to 33 in 43301a1
def fetchRemotes(remotes: Seq[String], timeout: Duration)(implicit logger: Logger): Seq[FetchResult] = { | |
val outputLogger = new BufferingProcessLogger | |
val processResult = Process("git remote") ! outputLogger | |
processResult match { | |
case 0 => | |
logger.debug("Fetching remote sources...") | |
val remotes = outputLogger.stdout | |
val tagsToFetch = remotes.filter(remotes.contains) |
The remotes
parameter is shadowed by the remotes
val. So the parameter is never used.
Not sure how best to fix this, since I don't yet understand what the code is supposed to do :)
Metadata
Metadata
Assignees
Labels
No labels