Re-add upsell_ids as backwards compatible accessor + trait for product

links

Author: Jade-GG

src/Models/Product.php

@@ -18,6 +18,7 @@
 use Rapidez\Core\Models\Traits\HasAlternatesThroughRewrites;
 use Rapidez\Core\Models\Traits\HasCustomAttributes;
 use Rapidez\Core\Models\Traits\Product\BackwardsCompatibleAccessors;
+use Rapidez\Core\Models\Traits\Product\HasProductLinks;
 use Rapidez\Core\Models\Traits\Product\HasSuperAttributes;
 use Rapidez\Core\Models\Traits\Product\Searchable;
 use Rapidez\Core\Models\Traits\UsesCallbackRelations;
@@ -27,6 +28,7 @@ class Product extends Model
     use BackwardsCompatibleAccessors;
     use HasAlternatesThroughRewrites;
     use HasCustomAttributes;
+    use HasProductLinks;
     use HasSuperAttributes;
     use Searchable;
     use UsesCallbackRelations;
@@ -152,40 +154,6 @@ protected function grouped(): Attribute
         return Attribute::get(fn () => $this->children);
     }
 
-    public function productLinks(): HasMany
-    {
-        return $this->hasMany(
-            config('rapidez.models.product_link', ProductLink::class),
-            'product_id', 'entity_id',
-        );
-    }
-
-    public function productLinkParents(): HasMany
-    {
-        return $this->hasMany(
-            config('rapidez.models.product_link', ProductLink::class),
-            'linked_product_id', 'entity_id',
-        );
-    }
-
-    public function getLinkedProducts(string $type): Collection
-    {
-        return $this->productLinks()
-            ->with('linkedProduct')
-            ->where('code', $type)
-            ->get()
-            ->pluck('linkedProduct');
-    }
-
-    public function getLinkedParents(string $type): Collection
-    {
-        return $this->productLinkParents()
-            ->with('linkedParent')
-            ->where('code', $type)
-            ->get()
-            ->pluck('linkedParent');
-    }
-
     public function categoryProducts(): HasMany
     {
         return $this

src/Models/Traits/Product/BackwardsCompatibleAccessors.php

@@ -37,4 +37,24 @@ protected function inStock(): Attribute
     {
         return Attribute::get(fn () => $this->stock->is_in_stock);
     }
+
+    /**
+     * @deprecated please use $product->upsells()->pluck('linked_product_id')
+     */
+    public function upsellIds(): Attribute
+    {
+        return Attribute::get(fn () =>
+            $this->upsells()->pluck('linked_product_id')
+        );
+    }
+
+    /**
+     * @deprecated please use $product->relationProducts()->pluck('linked_product_id')
+     */
+    public function relationIds(): Attribute
+    {
+        return Attribute::get(fn () =>
+            $this->relationProducts()->pluck('linked_product_id')
+        );
+    }
 }

src/Models/Traits/Product/HasProductLinks.php

@@ -0,0 +1,55 @@
+<?php
+
+namespace Rapidez\Core\Models\Traits\Product;
+
+use Illuminate\Database\Eloquent\Relations\HasMany;
+use Rapidez\Core\Models\ProductLink;
+
+trait HasProductLinks
+{
+    public function productLinks(): HasMany
+    {
+        return $this->hasMany(
+            config('rapidez.models.product_link', ProductLink::class),
+            'product_id', 'entity_id',
+        );
+    }
+
+    public function productLinkParents(): HasMany
+    {
+        return $this->hasMany(
+            config('rapidez.models.product_link', ProductLink::class),
+            'linked_product_id', 'entity_id',
+        );
+    }
+
+    public function linkedProducts(string $type): HasMany
+    {
+        return $this->productLinks()->where('code', $type);
+    }
+
+    public function linkedParents(string $type): HasMany
+    {
+        return $this->productLinkParents()->where('code', $type);
+    }
+
+    public function relationProducts(): HasMany
+    {
+        return $this->linkedProducts('relation');
+    }
+
+    public function superProducts(): HasMany
+    {
+        return $this->linkedProducts('super');
+    }
+
+    public function upsells(): HasMany
+    {
+        return $this->linkedProducts('up_sell');
+    }
+
+    public function crosssells(): HasMany
+    {
+        return $this->linkedProducts('cross_sell');
+    }
+}

tests/Unit/ProductTest.php

@@ -56,8 +56,8 @@ public function product_can_have_upsells_and_crosssells()
     {
         $product = Product::find(1578);
 
-        $this->assertEquals(8, $product->getLinkedProducts('up_sell')->count(), 'Product 1578 does not have 8 upsells.');
-        $this->assertEquals(4, $product->getLinkedProducts('cross_sell')->count(), 'Product 1578 does not have 4 crosssells.');
+        $this->assertEquals(8, $product->linkedProducts('up_sell')->count(), 'Product 1578 does not have 8 upsells.');
+        $this->assertEquals(4, $product->linkedProducts('cross_sell')->count(), 'Product 1578 does not have 4 crosssells.');
     }
 
     #[Test]