Improve slider items on mobile devices #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roene-JustBetter
requested review from
indykoning and
royduin
as code owners
JimmyHoenderdaal
requested changes
Sep 30, 2025
There was a problem hiding this comment.
This doesn't look that good, can you check this
There was a problem hiding this comment.
Any suggestions how you want to show it. The sliders here doesn't look good with a w-1/2 https://github.com/rapidez/reviews/blob/master/tests/playwright/reviews.spec.js-snapshots/product-with-reviews-1-Mobile-Safari-linux.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the visual improvements on the product tile with the color and size swatches. But on sliders especially on mobile it was looking a bit strange. I changed it for smaller screens so the items will have a
w-fullinstead ofw-1/2. I also changed the buttons in the slider so on small screens otherwise the buttons are above the product name / price.