[4.x] Make labels not clip outside of the frame & allow them to show together with inputs #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jade-GG
changed the title
Roene-JustBetter
requested changes
Oct 6, 2025
There was a problem hiding this comment.
This doesn't look good. It should be the inputs or the labels not both.
There was a problem hiding this comment.
Why not? @jordythevulder opinion? We can also just disable the extra labels by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these labels would clip outside of the container of the filters. Because they're wrapped in a
detailselement, this means they will clip as if it were anoverflow-hiddenelement. I've fixed this by making the labels move around so that they'll be hanging left of the thumb when on the right side, and hanging right of the thumb on the left side. See screenshots:I also added a
labelsprop so that we can actually display the labels together with the inputs. As it turns out, we never noticed this bug because we always use the inputs and never show the labels.