Frontend - autocomplete #547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jade-GG
requested changes
Aug 22, 2024
resources/views/layouts/partials/header/autocomplete/categories.blade.php
Outdated
Show resolved
Hide resolved
JimmyHoenderdaal
previously approved these changes
Aug 26, 2024
Jade-GG
previously approved these changes
Aug 27, 2024
jordythevulder
previously approved these changes
Sep 6, 2024
Jade-GG
previously approved these changes
Sep 6, 2024
royduin
requested changes
Sep 6, 2024
Comment on lines
38
to
40
| {{-- These classes are only used when you come from a page with a product listing, --}} | ||
| {{-- click on a link that leads to a 404 page and try to use the search there --}} | ||
| class="relative [&_*]:!m-0 [&_[isclearicon=]]:!mr-2 [&_.cancel-icon]:!fill-[#595959] [&_[groupposition=right]]:!absolute [&_[groupposition=right]]:!top-2/4 [&_[groupposition=right]]:!right-0 [&_[groupposition=right]]:!-translate-y-2/4" | ||
| class="relative [&_*]:!m-0" |
There was a problem hiding this comment.
I have tested the case local:
- Created a link that leads to a 404 page.
- Navigated to a page where a product listing is used.
- Clicked on the link that leads to a 404 page.
- Used the autocomplete to search.
Tested running yarn dev & yarn prod
resources/views/layouts/partials/header/autocomplete/products.blade.php
Outdated
Show resolved
Hide resolved
Roene-JustBetter
commented
Oct 1, 2024
tailwind.config.js
Outdated
| inactive: 'rgb(var(--inactive) / <alpha-value>)', // Inactive text color | ||
| inactive: { | ||
| DEFAULT: 'rgb(var(--inactive) / <alpha-value>)', // Inactive text color | ||
| 100: 'rgb(var(--inactive-100) / <alpha-value>)', // Inactive light background color |
There was a problem hiding this comment.
#580 --> inactive will change here.
Jade-GG
requested changes
Oct 9, 2024
resources/views/layouts/partials/header/autocomplete/no-results.blade.php
Outdated
Show resolved
Hide resolved
resources/views/layouts/partials/header/autocomplete/no-results.blade.php
Show resolved
Hide resolved
resources/views/layouts/partials/header/autocomplete/no-results.blade.php
Outdated
Show resolved
Hide resolved
…ve max-md for overflow-clip
Jade-GG
previously approved these changes
Oct 9, 2024
JimmyHoenderdaal
previously approved these changes
Oct 14, 2024
jordythevulder
previously approved these changes
Oct 15, 2024
|
Could you arrange a follow-up on this with the latest changes implemented like the colors and named z-indexes? |
Roene-JustBetter
dismissed stale reviews from jordythevulder and JimmyHoenderdaal
via
4ec268b
|
Moved this Pull request to a new one because this one is created from a fork. New pull request can be found here: #670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Hover:
What is changed: