-
Notifications
You must be signed in to change notification settings - Fork 13
Implement EAV structure for product entity #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jade-GG
wants to merge
47
commits into
master
Choose a base branch
from
feature/flat-tables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd enabled status
Jade-GG
commented
Jul 24, 2025
Jade-GG
commented
Jul 24, 2025
…into feature/flat-tables
b167b96
to
2240d05
Compare
[Flat tables] Add tier pricing
royduin
reviewed
Sep 2, 2025
->sortBy('store_id') | ||
->keyBy('option_id') | ||
); | ||
return Attribute::get(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object caching is there by default? https://laravel.com/docs/master/eloquent-mutators#value-object-caching, but there is also a caching option: https://laravel.com/docs/master/eloquent-mutators#accessor-caching
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #942, this is my alternative version, which includes attribute options and uses joins for attribute data & option values (but a relation for the options themselves).Based on better benchmarks and cleaner relations, we have chosen to keep this approach as opposed to #942. I've taken some of the extra functionality from there and have implemented into this PR.
With this PR we end up having 13 queries in total for products (regardless of how many products you query):
I've also made a small
backend_model
thing to parse data that may be in a weird format but I don't really know if this is a worthwhile thing to have abstracted like this. This is currently only used for comma separated values.This also includes #944 currently, to add support for querying based on attributes. This is necessary to filter products based on the
status
attribute.Current to do list:
selectForProductPage