Skip to content

Support cum_sum(...).over(...) expressions in cudf-polars #19908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Oct 9, 2025
Merged

Support cum_sum(...).over(...) expressions in cudf-polars #19908

merged 38 commits into from
Oct 9, 2025
+105 −2

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 5, 2025 •
edited
Loading

Description

Contributes to #19200 by unblocking Q51

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Matt711 and others added 24 commits August 22, 2025 14:36
@Matt711
Some clarifications, improvements to GroupedRollingWindows in cudf-po…
dd8764e 
…lars
@Matt711
clean up
c60a6e2
@Matt711
Merge branch 'branch-25.10' into imp/polars/over
a94b6ab
@Matt711
Merge branch 'branch-25.10' into imp/polars/over
57c6b4b
@Matt711
Support rank(...).over(...) expressions in cudf-polars
3fda0a0
@Matt711
merge conflict
23e639b
@Matt711
implement dense, min, max, and average
4ceedf2
@Matt711
Merge branch 'branch-25.10' into fea/polars/rank-over
f7301bb
@Matt711
add version guards
d0522b0
@Matt711
Merge branch 'branch-25.10' into fea/polars/rank-over
1fc7711
@Matt711
use a single groupby scan
e3ee3bd
@Matt711
Merge branch 'branch-25.10' into fea/polars/rank-over
a197348
@Matt711
Merge branch 'branch-25.10' into fea/polars/rank-over
8694426
@Matt711
address review
099a03c
@Matt711
Support ordered grouped windows in cudf-polars
fea62a7
@Matt711
Merge branch 'branch-25.10' into fea/polars/over-expr-with-orderby
0bfe8bc
@Matt711
Merge branch 'branch-25.10' into fea/polars/over-expr-with-orderby
14d637f
@Matt711
catch streaming test warning
b17d867
@Matt711
Merge branch 'branch-25.10' into fea/polars/over-expr-with-orderby
ba233bf
@Matt711
Merge branch 'branch-25.10' into fea/polars/over-expr-with-orderby
24b27f8
@Matt711
make unary op implementations easier to support
5693e76
@Matt711
not yet
5ecaedc
@Matt711
Support forward/backward filling null values in a grouped window context
1bec1b7
@Matt711
Support cum_sum(...).over(...) expressions in cudf-polars
1a298d5
@Matt711 Matt711 requested a review from a team as a code owner September 5, 2025 21:59
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Sep 5, 2025
@Matt711 Matt711 marked this pull request as draft September 6, 2025 22:39
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 6, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 7, 2025

/ok to test d25e0c3

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 7, 2025

/ok to test ac65b75

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 9, 2025

/ok to test 2a7a8a8

@mroeschke mroeschke mentioned this pull request Sep 16, 2025
Merged
3 tasks
@Matt711 Matt711 changed the base branch from branch-25.10 to branch-25.12 October 8, 2025 21:35
@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Oct 8, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 8, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 8, 2025

/ok to test f1989a9

@Matt711 Matt711 marked this pull request as ready for review October 8, 2025 23:55
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 9, 2025

/ok to test 48fb152

@Matt711 Matt711 requested a review from mroeschke October 9, 2025 01:33
wence-
wence- approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense to me with one small comment.

python/cudf_polars/cudf_polars/dsl/expressions/rolling.py
Comment on lines 302 to 306
val_col = plc.copying.gather(
plc.Table([val_col]),
order_index,
plc.copying.OutOfBoundsPolicy.NULLIFY,
).columns()[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was resolved, but it seems not addressed (or explained why this would be a bad idea).

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 9, 2025

/merge

@rapids-bot rapids-bot bot merged commit 81adc6d into rapidsai:branch-25.12 Oct 9, 2025
138 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 9, 2025
@Matt711 Matt711 deleted the fea/polars/cum-sum-over branch October 9, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wence- wence- wence- approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees

@Matt711 Matt711

Labels

cudf-polars Issues specific to cudf-polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matt711 @wence- @mroeschke