Reduce output buffer sizes for pruned pages of columns with a list parent
#20086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Currently has a bug where if chunking actually occurs, things get messed up. In other words, it works with the chunked reader, but only if chunking does not occur.
…n the new flow of the code, causing issues during chunked reads.
…ber of variables being set in many disparate places that got unordered by the code rearrangement. We just have a whole lot of state that's tricky to keep track of these days.
…nate non-empty nulls
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mhaseeb123
added
2 - In Progress
mhaseeb123
commented
Sep 23, 2025
| return std::pair{std::move(table), std::move(buffer)}; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
All this simply moved as is from hybrid_scan_test.cpp. No need to review
| return cudf::test::strings_column_wrapper(elements, elements + num_ordered_rows); | ||
| } | ||
|
|
||
| std::unique_ptr<cudf::table> concatenate_tables(std::vector<std::unique_ptr<cudf::table>> tables, |
There was a problem hiding this comment.
All this simply moved as is from hybrid_scan_test.cpp. No need to review
mhaseeb123
requested review from
kingcrimsontianyu,
vuule,
nvdbaranec and
pmattione-nvidia
mhaseeb123
commented
Sep 29, 2025
| * @param page_mask Page mask indicating if this column needs to be decoded | ||
| * @param min_rows crop all rows below min_row | ||
| * @param num_rows Maximum number of rows to read | ||
| * other settings and records the result in the PageInfo::str_bytes_all field |
mhaseeb123
changed the title
list parentlist parent
mhaseeb123
added
4 - Needs Review
3 tasks
mhaseeb123
commented
Oct 7, 2025
vuule
approved these changes
Oct 7, 2025
Co-authored-by: Vukasin Milovanovic <vmilovanovic@nvidia.com>
|
pre-commit.ci autofix |
pmattione-nvidia
approved these changes
Oct 8, 2025
kingcrimsontianyu
approved these changes
Oct 8, 2025
mhaseeb123
added
5 - Ready to Merge
|
/ok to test a471b6e |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #19986.
This PR reduces the output column buffer sizes needed to materialize columns with a list parent such as
list<list<...>>,list<str>,list<list<..<str>..>>etc. against pruned parquet pages in the next-gen reader. By doing so, we also eliminate non-empty nulls across list hierarchies speeding up their materialization.Checklist