Skip to content

Remove compatibility with nvCOMP versions before 5.0 #20140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 8, 2025
Merged

Remove compatibility with nvCOMP versions before 5.0 #20140

merged 11 commits into from
Oct 8, 2025

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Sep 29, 2025 •
edited
Loading

Description

Remove the nvCOMP adapter parts that called the older APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule self-assigned this Sep 29, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vuule vuule changed the title Remove compatibility with nvCOMP version before 5.0 Remove compatibility with nvCOMP versions before 5.0 Sep 29, 2025
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 29, 2025
@vuule vuule added improvement Improvement / enhancement to an existing function breaking Breaking change labels Sep 29, 2025
@vuule vuule marked this pull request as ready for review October 6, 2025 22:42
@vuule vuule requested a review from a team as a code owner October 6, 2025 22:42
kingcrimsontianyu
kingcrimsontianyu reviewed Oct 7, 2025
View reviewed changes
kingcrimsontianyu
kingcrimsontianyu reviewed Oct 7, 2025
View reviewed changes
@vuule
Copy link
Contributor Author

vuule commented Oct 7, 2025

/ok to test 3488aa0

kingcrimsontianyu
kingcrimsontianyu approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 7, 2025
@vuule
Copy link
Contributor Author

vuule commented Oct 8, 2025

/ok to test 9f582fd

@vuule
Copy link
Contributor Author

vuule commented Oct 8, 2025

/merge

@rapids-bot rapids-bot bot merged commit b328fc0 into rapidsai:branch-25.12 Oct 8, 2025
132 checks passed
@vuule vuule deleted the impr-remove-nvcomp-4 branch October 8, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@kingcrimsontianyu kingcrimsontianyu kingcrimsontianyu approved these changes

Assignees

@vuule vuule

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vuule @bdice @kingcrimsontianyu