Skip decompression of pruned parquet pages #20192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mhaseeb123
added
feature request
4 tasks
mhaseeb123
added
3 - Ready for Review
mhaseeb123
commented
Oct 8, 2025
| return 0; | ||
| } | ||
|
|
||
| // If this page is pruned and has a list parent, set the batch size for this depth to 0 to |
There was a problem hiding this comment.
Removing this what we added in (#20086) since we are taking care of page sizes (and batch sizes) in compute_page_sizes_kernel instead.
mhaseeb123
commented
Oct 8, 2025
| thrust::make_counting_iterator<size_t>(key_start), | ||
| thrust::make_counting_iterator<size_t>(key_start + num_keys_this_iter), | ||
| size_input.begin(), | ||
| get_page_nesting_size{ |
There was a problem hiding this comment.
page_mask.data() not needed anymore
mhaseeb123
commented
Oct 8, 2025
| return; | ||
| } | ||
|
|
||
| if (page_mask.size() and not page_mask[page_idx]) { |
There was a problem hiding this comment.
@nvdbaranec @pmattione-nvidia please review this if block
mhaseeb123
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #20086 and #19986.
This PR enables skipping decompression of parquet data pages marked as pruned in the new experimental parquet reader. This PR also zeros out nesting size information (used to allocate output buffers) for pruned pages right when it's being computed instead of resetting it later-on just before buffer allocation in (#20086).
Checklist