Skip to content

Require CMake 3.30.4, and latest CPM #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2025
Merged

Require CMake 3.30.4, and latest CPM #753

merged 4 commits into from
Feb 26, 2025

Conversation

robertmaynard
Copy link
Contributor

Description

By requiring CMake 3.30.4+ we remove all the CPM related policy deprecation warnings that rapids-cmake users see.

Fixes #680

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added breaking Introduces a breaking change feature request New feature or request 3 - Ready for Review Ready for review by team labels Jan 27, 2025
@robertmaynard robertmaynard requested review from a team as code owners January 27, 2025 19:10
@robertmaynard robertmaynard requested review from bdice and removed request for a team January 27, 2025 19:10
KyleFromNVIDIA
KyleFromNVIDIA reviewed Jan 27, 2025
View reviewed changes
@robertmaynard robertmaynard added DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team labels Feb 5, 2025
@robertmaynard
Copy link
Contributor Author

Want to bump the cmake minimum required version in each rapids project before we merge this

@jameslamb jameslamb mentioned this pull request Feb 18, 2025
Merged
@robertmaynard robertmaynard mentioned this pull request Feb 19, 2025
Closed
12 tasks
@robertmaynard
Copy link
Contributor Author

Due to cpm-cmake/CPM.cmake#630 we need to pin to CPM v0.40.2 before merging

bdice
bdice approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine! One small question.

All the other RAPIDS PRs are merged, so this should be unblocked. @robertmaynard I'll let you merge when you're ready.

@bdice
Copy link
Contributor

bdice commented Feb 26, 2025

Due to cpm-cmake/CPM.cmake#630 we need to pin to CPM v0.40.2 before merging

I see we pinned to 0.40.5 here. Do we need to downgrade? Or just use >= 0.40.2?

@robertmaynard robertmaynard removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 26, 2025
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a8288b5 into rapidsai:branch-25.04 Feb 26, 2025
17 checks passed
@pxLi pxLi mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

Assignees
No one assigned
Labels
breaking Introduces a breaking change feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] some RAPIDS repos are incompatible with CPM 0.40.2
3 participants
@robertmaynard @bdice @KyleFromNVIDIA