Require CMake 3.30.4, and latest CPM#753
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.04from Feb 26, 2025
Merged
Require CMake 3.30.4, and latest CPM#753rapids-bot[bot] merged 4 commits intorapidsai:branch-25.04from
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.04from
Conversation
robertmaynard
added
breaking
KyleFromNVIDIA
approved these changes
Feb 4, 2025
robertmaynard
added
DO NOT MERGE
Contributor
Author
|
Want to bump the cmake minimum required version in each rapids project before we merge this |
12 tasks
Contributor
Author
|
Due to cpm-cmake/CPM.cmake#630 we need to pin to CPM v0.40.2 before merging |
bdice
approved these changes
Feb 25, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
All looks fine! One small question.
All the other RAPIDS PRs are merged, so this should be unblocked. @robertmaynard I'll let you merge when you're ready.
Contributor
I see we pinned to 0.40.5 here. Do we need to downgrade? Or just use |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By requiring CMake 3.30.4+ we remove all the CPM related policy deprecation warnings that rapids-cmake users see.
Fixes #680
Checklist