-
Notifications
You must be signed in to change notification settings - Fork 226
[RELEASE] rmm v25.10 #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AyodeAwe
wants to merge
36
commits into
main
Choose a base branch
from
branch-25.10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RELEASE] rmm v25.10 #2052
+1,700
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-merge branch-25.08 into branch-25.10
Forward-merge branch-25.08 into branch-25.10
Forward-merge branch-25.08 into branch-25.10
This PR removes the OS suffix from devcontainers, allowing the upstream devcontainer images to determine the OS version. Contributes to rapidsai/build-planning#200. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1997
conda-forge is migrating to gcc 14, so this PR is updating for alignment. See rapidsai/build-planning#188 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Bradley Dice (https://github.com/bdice) URL: #1963
rapids_config will use `RAPIDS_BRANCH` contents to determine what branch to use Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #1994
`std::equal` was basically being used to create a loop, which `std::for_each` is better suited for. See discussion at #1963 (comment) Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Yunsong Wang (https://github.com/PointKernel) URL: #1999
Continues from #1980. Contributes to #1779. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Rong Ou (https://github.com/rongou) URL: #1983
## Summary This pull request has been generated by [StepSecurity](https://app.stepsecurity.io/github/rapidsai/actions/dashboard) as part of your enterprise subscription to ensure compliance with recommended security best practices. Please review and merge the pull request to apply these security enhancements. ## Security Fixes ### Harden Runner Harden-Runner is an open-source security agent for the GitHub-hosted runner to prevent software supply chain attacks. It prevents exfiltration of credentials, detects tampering of source code during build, and enables running jobs without sudo access. - [GitHub Security Guide](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions) - [The Open Source Security Foundation (OpenSSF) Security Guide](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dangerous-workflow) ### Least Privileged GitHub Actions Token Permissions The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN. - [GitHub Security Guide](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) - [The Open Source Security Foundation (OpenSSF) Security Guide](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) ## Feedback For bug reports, feature requests, and general feedback; please create an issue in [step-security/secure-repo](https://github.com/step-security/secure-repo) or contact us via [our website](https://www.stepsecurity.io/). Authors: - https://github.com/apps/stepsecurity-app Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #2000
) Fixes #2002. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Lawrence Mitchell (https://github.com/wence-) URL: #2003
CUDA 13 removes the `cudaMemAdvise` and `cudaMemPrefetchAsync` function signatures used by RMM. To continue to support CUDA 12 and 13 we move over to the v2 APIs when in CUDA 12, which are now the unversioned APIs in 13. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2004
Bumps the version of `actions/labeler` to `@v5` and updates the syntax in the `labeler.yml` file to account for breaking changes in that version bump. xref: rapidsai/ops#2968 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) URL: #2006
Issue: rapidsai/build-planning#207 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2007
Forward-merge branch-25.08 into branch-25.10
This works around the failures observed in #1935 by disabling system memory resource tests on systems with HMM and CUDA drivers older than 12.8 (R575). I did some local testing with driver R550, which is old enough to reproduce the bug when used with a Linux kernel new enough to support HMM. I believe the system memory resource works as intended on HMM systems with earlier CUDA drivers, but it appears that [is_device_accessible_memory](https://github.com/rapidsai/rmm/blob/e1d777a5e3dd1306970432a35d0f868ccf67f523/cpp/tests/mr/device/test_utils.hpp#L30-L35) returns false for the system-allocated pointers. This may be a driver bug, as the pointers seem to be device-accessible if, e.g., accessed from a CUDA kernel. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Lawrence Mitchell (https://github.com/wence-) - Robert Maynard (https://github.com/robertmaynard) URL: #1944
This adds a dependency on `numba-cuda`. Previously, RMM depended on only `numba`, and the CUDA target in `numba` is [deprecated in favor of `numba-cuda`](https://numba.readthedocs.io/en/stable/cuda/overview.html#cuda-deprecation-status). The fixes needed to support CUDA driver 580+ are in `numba-cuda`, so we adopt it here. The version pinning chosen here is `>=0.14.0,<0.15.0a0` to align with the current version pinning used elsewhere in RAPIDS (cudf, ucxx, etc.). See also: numba/numba#10166 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #2013
rapids_config will use a user defined branch over `RAPIDS_BRANCH` contents Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Jake Awe (https://github.com/AyodeAwe) - Bradley Dice (https://github.com/bdice) URL: #2010
This PR updates the numba-cuda version to `>=0.18.0,<0.19.0a0`. xref: rapidsai/cudf#19604 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #2019
Changes the pylibrmm `Stream.view()` method from `except *` to `noexcept`. This prevents many warnings where the `view()` method. Here is an example: https://github.com/rapidsai/cudf/actions/runs/17040978623/job/48305629155?pr=19446#step:12:735 ``` performance hint: /__w/cudf/cudf/python/pylibcudf/pylibcudf/reduce.pyx:57:20: Exception check after calling 'view' will always require the GIL to be acquired. Declare 'view' as 'noexcept' if you control the definition and you're sure you don't want the function to raise exceptions. ``` Also changed the `is_default()` to `noexcept` since the underlying librmm function is also declared as `noexcept`. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Matthew Murray (https://github.com/Matt711) - Bradley Dice (https://github.com/bdice) URL: #2020
This PR adds CUDA 13.0.0 devcontainers. Contributes to rapidsai/build-planning#208. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #2012
Some minor improvements to the README. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Tom Augspurger (https://github.com/TomAugspurger) URL: #2018
Contributes to rapidsai/build-planning#208 This PR uses CUDA 13.0.0 to build and test. Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2021
RAPIDS has deployed an autoscaling cloud build cluster that can be used to accelerate building large RAPIDS projects. This contributes to rapidsai/build-planning#209. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2016
Aligns with changes being made in other repos for CUDA 13 bringup. Contributes to rapidsai/build-planning#208. Also contributes to rapidsai/build-planning#68. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2022
Refactors device capability checks, add concurrent managed access checks to skip prefetching tests on WSL (not supported). One motivation for this refactoring is that the previous names really didn't make much sense. We created the `runtime_async_alloc::is_supported()` to check for CUDA 11.2+ support for runtime async allocation. However, we tacked on other features like `is_export_handle_type_supported(cudaMemAllocationHandleType)` and `is_hwdecompress_supported()` into the same struct. Those should have been their own features, not tied to `runtime_async_alloc`. Most of the changes in this PR are structurally similar to that. Closes #2023. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Tom Augspurger (https://github.com/TomAugspurger) - Matthew Murray (https://github.com/Matt711) - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #2014
We need some fixes from NVIDIA/numba-cuda#424 to fully support `numba==0.60` and CUDA 13. This bumps the `numba-cuda` dependency to `>=0.19.1,<0.20.0a0`. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #2024
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - James Lamb (https://github.com/jameslamb) URL: #2027
Contributes to rapidsai/build-planning#208 Now that rapidsai/shared-workflows#413 is merged, this converts all GitHub Actions references from `@cuda13.0` back to `branch-25.10`. ## Notes for Reviewers This is safe to admin-merge because the change is a no-op... configs on those 2 branches are identical.
…from the CUDA runtime (#2028) This PR avoids deadlocks resulting from two Python threads simultaneously contending for both the GIL and the CUDA lock where one is running rmm code and the other is running CUDA code from another Python package calling CUDA functions. Resolves #2026 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2028
Contributes to rapidsai/build-planning#214, updating pins to match the rest of RAPIDS: * `cuda-python` (>=12.9.2 for CUDA 12, >=13.0.1 for CUDA 13) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2031
) Closes #1941. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Lawrence Mitchell (https://github.com/wence-) URL: #2025
This PR allows building with CCCL 3.1.0. Contributes to #2011. Authors: - Bradley Dice (https://github.com/bdice) - Basit Ayantunde (https://github.com/lamarrr) Approvers: - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) URL: #2017
This PR configures this repo (adds a `.github/release.yml` file) for automatic release notes generation. See https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes. This will fix such issues as hotfix releases including wrong content (e.g [cugraph v25.04.01](https://github.com/rapidsai/cugraph/releases/tag/v25.04.01) contains 50+ PRs from the full v25.04.00 release when it should only contain the single hotfix PR (#5017).) Example auto-generated release notes: https://github.com/rapidsai/literate-octo-potato/releases/tag/v25.10.00a
Add optional flag argument to both `cuda_stream` and `cuda_stream_pool` creation to allow caller to specify whether the resulting stream should be implicitly synchronising with the default stream. - Closes #2029 Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) URL: #2036
## Description Closes #2057. This fix only affects builds with CCCL 3.1.0+. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-25.10
and v25.10 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-25.10
until release (merging of this PR).What is the purpose of this PR?
branch-25.10
intomain
for the release