Fix bug in pinned_memory_resource with CCCL 3.1.x. #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am recommending this for a merge during code freeze because this bug affects downstream builds with CCCL 3.1.0, which we would like to support at build time in RAPIDS 25.10. We won't be upgrading RAPIDS to CCCL 3.1.0 until the 25.12 release, but having build-time support for CCCL 3.1.0 will be useful for future builds based on this release. The risk of breaking things is very low because the change is only active when CCCL 3.1.0 or higher is available. |
bdice
commented
Sep 27, 2025
Comment on lines
+155
to
+160
| // Explicitly inherit the allocate and deallocate functions from the host_memory_resource class. | ||
| // Due to inheritance and name hiding rules, we need to declare these with "using" when we | ||
| // override allocate and deallocate for CCCL 3.1.0+ compatibility. | ||
| using host_memory_resource::allocate; | ||
| using host_memory_resource::deallocate; | ||
|
|
There was a problem hiding this comment.
Reviewers: these lines are the fix. If you prefer to limit the diff, I can punt on adding the tests until branch-25.12. Let me know if you'd prefer that.
bdice
changed the title
KyleFromNVIDIA
approved these changes
Sep 29, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2057.
This fix only affects builds with CCCL 3.1.0+.
Checklist