Fix 'getFile' async request #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs additional investigation, it shouldn't be dependent on queue |
|
Could it be some issue with calling code? I.e. for example if it's calling a blocking version of the method on main thread |
|
DispatchQueue.global().async doesn't make sense here as startDataTaskForEndpoint's callback is already on global queue (so directly calling completion() would have same effect), plus we must call the completion handler on the queue specified by caller (main queue by default). |
|
I tested now 'sendMessage' and 'deleteMessage' both not working. 'getUpdate' working well. code: |
|
Full trace: |
|
Is this reproducible in example apps? |
|
I don't know. I'll try to try it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this code not working correctly for 'getFile' endpoint.
Replacing the queue.async with DispatchQueue.global().async fixes this bug.
My system: MacBook 16 M1 Pro