Duplicate defines when using CMSIS headers

[Hexxeh]

Within https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/cmsis/stub/CMSIS/Device/RP2350/Source/system_RP2350.c I see there's includes for both RP2350.h and hardware/clocks.h. hardware/clocks.h includes the following chain of headers: pico.h -> pico/platform.h -> hardware/regs/addressmap.h. This last file seems to duplicate many defines from RP2350.h.

How are are the CMSIS headers intended to be used without causing duplicate defines?

[kilograham]

GCC does not complain at standard warning levels as the values are somewhat the same (signed vs unsigned) - arguably this is a bit surprising, but meant that our simple compilation sanity checks pass. pico-examples builds with more warnings, but evidently does not use CMSIS anywhere

[kilograham]

ok, it seems that GCC does not complain as these are system headers (are you using the normal cmake build system?, or a particular compiler version?) - or

you can make the build fail by passing -Wsystem-headersor indeed pass by -Wno-system-headers which is the default.

We can remove the duplicates in 2.2.0 but not doing so now as there are other compilation issues with -Wsystem-headers

[Hexxeh]

I'm not using CMake (because the project I'm trying to add support to doesn't use it, it uses waf), and I'm using the ARM provided toolchain from here: https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (version 14.2.1).

I'll give -Wno-system-headers a try, we're not setting -Wsystem-headers based on a quick grep, but there are probably other oddities about this build system.

[kilograham]

to be clear, the CMake build adds the SDK headers (including the CMSIS ones) to the system include path - that is probably the facet that is missing from your build. see for example #82

[Hexxeh]

Ah, yes, that's probably the issue. I think we're just specifying everything with -I. I will try to rejig the build to use -isystem. Thank you!