-
Notifications
You must be signed in to change notification settings - Fork 139
RDoc-3375 Data archival feature (C#) #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDoc-3375 Data archival feature (C#) #2057
Conversation
{PANEL: Schedule a SINGLE document for archiving - from the Client API} | ||
|
||
To schedule a single document for archival from the Client API, | ||
add the `@archive-at` property directly to the document metadata as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we say "To schedule a single document for archival, after you already configured data archival, from the Client API ..." ?
Someone may scroll down and think it's doable atomically 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true for all 4 panels in this article, not just for the client api example,
so I’m emphasizing the existing point in the general introductory note at the beginning.
|
||
{NOTE: } | ||
|
||
* Archived documents can be unarchived at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make a note here, that deleting @archived: true from metadata won't drop document flag, so it's not enough, not that simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -257,6 +257,7 @@ | |||
* **Misc**: | |||
ConfigureExpirationOperation | |||
ConfigureRefreshOperation | |||
ConfigureDataArchivalOperation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we have it already, @yh-0 could you verify that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not a single mention of 'archival' in the entire python client repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yh-0 let's create a ticket on our clients board for implementing ConfigureDataArchivalOperation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, this is great!
Related issues:
https://issues.hibernatingrhinos.com/issue/RDoc-3375/C-Server-Extensions-Data-archival-Fix-article
https://issues.hibernatingrhinos.com/issue/RDoc-3376/Documents-created-by-patching-archived-documents-cant-be-unarchived
https://issues.hibernatingrhinos.com/issue/RDoc-3307/Document-patching-allow-updating-archive-at-metadata-property