Skip to content

RDoc-3375 Data archival feature (C#) #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

@Danielle9897 Danielle9897 requested a review from poissoncorp June 26, 2025 18:30
{PANEL: Schedule a SINGLE document for archiving - from the Client API}

To schedule a single document for archival from the Client API,
add the `@archive-at` property directly to the document metadata as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say "To schedule a single document for archival, after you already configured data archival, from the Client API ..." ?
Someone may scroll down and think it's doable atomically 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true for all 4 panels in this article, not just for the client api example,
so I’m emphasizing the existing point in the general introductory note at the beginning.


{NOTE: }

* Archived documents can be unarchived at any time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a note here, that deleting @archived: true from metadata won't drop document flag, so it's not enough, not that simple

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -257,6 +257,7 @@
* **Misc**:
       ConfigureExpirationOperation
       ConfigureRefreshOperation
       ConfigureDataArchivalOperation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have it already, @yh-0 could you verify that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not a single mention of 'archival' in the entire python client repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yh-0 let's create a ticket on our clients board for implementing ConfigureDataArchivalOperation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@poissoncorp poissoncorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, this is great!

@Danielle9897 Danielle9897 requested a review from poissoncorp July 15, 2025 13:12
@ppekrol ppekrol merged commit 6cfd9f8 into ravendb:master Jul 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants