Skip to content

Create FileReader abstraction for FeatherFileReader and ParquetFileReader #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kprafull opened this issue Feb 4, 2025 · 1 comment
Open

Create FileReader abstraction for FeatherFileReader and ParquetFileReader #482

kprafull opened this issue Feb 4, 2025 · 1 comment
Assignees
@mcember
Labels
enhancement New feature or request P2 Resolve if not working on P0/P1 (< 4 weeks)
Milestone
Misc. Rivulet Imp...

Comments

@kprafull
Copy link

kprafull commented Feb 4, 2025

FeatherFileReader is mostly a copy-paste from ParquetFileReader and this ticket is to address the following TODO in the codebase:

Feather file reader. This class is not thread safe

This is mostly a copy-pasta from ParquetFileReader
TODO can consider abstracting code between this and ParquetFileReader

Acceptance criteria

  • Create abstract FileReader interface that can be used to read from Feather, Parquet and others in future
  • Update existing FeatherFileReader and ParquetFileReader to use FileReader
@pdames pdames added this to the Misc. Rivulet Improvements milestone Mar 24, 2025
@pdames pdames added enhancement New feature or request P2 Resolve if not working on P0/P1 (< 4 weeks) labels Mar 24, 2025
@zhaohaidao
Copy link

If no one is working on it, I would like to try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcember mcember

Labels
enhancement New feature or request P2 Resolve if not working on P0/P1 (< 4 weeks)
Projects
None yet
Milestone
Misc. Rivulet Improvements
Development

No branches or pull requests
4 participants
@kprafull @pdames @zhaohaidao @mcember