fix ray-service.different-port.yaml#3721
Merged
Merged
Conversation
Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
Contributor
Author
|
Hi @MortalHappiness, could you take a look? |
MortalHappiness
approved these changes
Jun 4, 2025
Member
|
Thanks for your contribution! |
Contributor
Author
|
Hello, if there are no further issues, please consider merging this PR :) @MortalHappiness @kevin85421 |
Member
|
Oh, I didn’t realize this was a bug fix. We’re currently working on the release and we’ve already cut the branch, so I haven’t been reviewing new PRs lately. I will merge this PR and cherry pick to the release branch. |
MortalHappiness
pushed a commit
to MortalHappiness/kuberay
that referenced
this pull request
Jun 11, 2025
4 tasks
chipspeak
pushed a commit
to chipspeak/kuberay
that referenced
this pull request
Jul 2, 2025
kryanbeane
pushed a commit
to kryanbeane/kuberay
that referenced
this pull request
Jul 2, 2025
CathalOConnorRH
pushed a commit
to CathalOConnorRH/kuberay
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#3262 cleaned up the
portsfield in the YAML files. However, theray-service.different-port.yamlshould at least retain the configuration for theserveport, as this YAML is specifically demonstrating how to customize the serve port.Related issue number
Checks