Skip to content

fix ray-service.different-port.yaml #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zjx20
Copy link

@zjx20 zjx20 commented May 31, 2025

Why are these changes needed?

#3262 cleaned up the ports field in the YAML files. However, the ray-service.different-port.yaml should at least retain the configuration for the serve port, as this YAML is specifically demonstrating how to customize the serve port.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

zjx20 added 3 commits May 31, 2025 12:13
Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
@zjx20
Copy link
Author

zjx20 commented Jun 4, 2025

Hi @MortalHappiness, could you take a look?

@MortalHappiness
Copy link
Member

Thanks for your contribution!

Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants