Skip to content

Commit d8c9481

Browse files
Omkar KulkarniOmkar Kulkarni
Omkar Kulkarni
authored and
Omkar Kulkarni
committed
feat: removing isolated test for component_file_name
Signed-off-by: Omkar Kulkarni <omkar@omkar-JKJHCX74L6.local>
1 parent b2b971b commit d8c9481

File tree

1 file changed

+18
-36
lines changed

1 file changed

+18
-36
lines changed

python/ray/serve/tests/test_deploy.py

+18-36
Original file line numberDiff line numberDiff line change
@@ -57,42 +57,24 @@ def d():
5757
assert pid3 != pid2
5858

5959

60-
@pytest.mark.parametrize("component_name",
61-
[
62-
"test@component",
63-
"test#123",
64-
"component/name",
65-
"component.name",
66-
"component!name",
67-
"component$name",
68-
"component%name",
69-
"component^name",
70-
"component&name",
71-
"component*name",
72-
"component(name",
73-
"component)name",
74-
"component+name",
75-
"component=name",
76-
"component{name",
77-
"component}name",
78-
"component[name",
79-
"component]name",
80-
"component:name",
81-
"component;name",
82-
"component'name",
83-
'component"name',
84-
"component<name",
85-
"component>name",
86-
"component,name",
87-
"component?name",
88-
"component|name",
89-
"component\\name",
90-
])
60+
@pytest.mark.parametrize(
61+
"component_name",
62+
[
63+
"test@component",
64+
"test#123",
65+
"component/name",
66+
"component.name",
67+
"component!name",
68+
"component$name",
69+
"component%name",
70+
"component^name",
71+
"component&name",
72+
"component*name",
73+
],
74+
)
9175
def test_deploy_with_special_characters(serve_instance, component_name):
92-
"""The function should not fail when the deployment name contains special characters.
93-
The deployment will use the names without special characters replaced by underscores.
94-
"""
95-
signal = SignalActor.options(name="some_signal").remote()
76+
"""The function should not fail when the deployment name contains special characters."""
77+
signal = SignalActor.options(name=f"signal-{get_random_string()}").remote()
9678

9779
# V1 blocks on signal
9880
@serve.deployment(name="some_name")
@@ -107,7 +89,7 @@ async def __call__(self):
10789
# Check that deployment succeeds with special characters
10890
with pytest.raises(Exception) as exc_info:
10991
serve.run(V1.options(name=component_name).bind(), name="app")
110-
92+
11193
assert exc_info.type is None, f"Deployment failed with exception: {exc_info.value}"
11294

11395

0 commit comments

Comments
 (0)