Skip to content

[data] update paramter name in save_csv #52542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[data] update paramter name in save_csv #52542

wants to merge 1 commit into from

Conversation

iamjustinhsu
Copy link
Collaborator

@iamjustinhsu iamjustinhsu commented Apr 23, 2025 •
edited
Loading

Why are these changes needed?

There are some things failing in the file

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@iamjustinhsu iamjustinhsu requested review from a team as code owners April 23, 2025 00:03
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 28, 2025
@masoudcharkhabi masoudcharkhabi added data Ray Data-related issues usability labels Apr 28, 2025
@richardliaw richardliaw changed the title update paramter name in save_csv [data] update paramter name in save_csv May 2, 2025
@richardliaw richardliaw added docs An issue or change related to documentation and removed usability community-contribution Contributed by the community labels May 2, 2025
@richardliaw
Copy link
Contributor

hey @iamjustinhsu - could you fix tests / dco?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
data Ray Data-related issues docs An issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamjustinhsu @richardliaw @masoudcharkhabi @hainesmichaelc